Skip to content

Commit c25e213

Browse files
committed
Remove secret_helper.py and update tests to exclude require-rf-7.4 for compatibility with older Robot Framework versions
1 parent b2e8aed commit c25e213

3 files changed

Lines changed: 4 additions & 21 deletions

File tree

atest/acceptance/keywords/textfields.robot

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Suite Setup Open Browser To Start Page Disabling Chrome Leaked Password Detection
33
Test Setup Go To Page "forms/prefilled_email_form.html"
44
Resource ../resource.robot
5-
Library ../../resources/testlibs/secret_helper.py
65
Force Tags Known Issue Internet Explorer
76

87
*** Test Cases ***
@@ -81,7 +80,6 @@ Attempt Clear Element Text On Non-Editable Field
8180
Input Password Accepts Secret Type
8281
[Tags] require-rf-7.4
8382
[Setup] Go To Page "forms/login.html"
84-
Skip If No Secret
8583
Set Environment Variable TEST_PASSWORD s3cret-pass
8684
VAR ${pw: Secret} %{TEST_PASSWORD}
8785
Input Text username_field my_username
@@ -92,7 +90,6 @@ Input Password Accepts Secret Type
9290
Input Text Accepts Secret Type
9391
[Tags] require-rf-7.4
9492
[Setup] Go To Page "forms/login.html"
95-
Skip If No Secret
9693
Set Environment Variable TEST_USERNAME my_username
9794
VAR ${user: Secret} %{TEST_USERNAME}
9895
Input Text username_field ${user}
@@ -111,8 +108,7 @@ Input Password Does Not Log Secret Value
111108
[Tags] require-rf-7.4 NoGrid
112109
[Setup] Go To Page "forms/login.html"
113110
[Documentation]
114-
... LOG 2:1 INFO Typing password into text field 'password_field'.
115-
Skip If No Secret
111+
... LOG 4:1 INFO Typing password into text field 'password_field'.
116112
Set Environment Variable TEST_PASSWORD must-not-leak
117113
VAR ${pw: Secret} %{TEST_PASSWORD}
118114
Input Password password_field ${pw}

atest/resources/testlibs/secret_helper.py

Lines changed: 0 additions & 16 deletions
This file was deleted.

atest/run.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import subprocess
5151
import tempfile
5252

53+
from packaging.version import Version
5354
from robot import rebot_cli
5455
from robot import __version__ as robot_version
5556
from selenium import __version__ as selenium_version
@@ -223,6 +224,8 @@ def execute_tests(interpreter, browser, rf_options, grid, event_firing, port):
223224
"--exclude",
224225
"triage",
225226
]
227+
if Version(robot_version) < Version("7.4"):
228+
options.extend(["--exclude", "require-rf-7.4"])
226229
command = runner
227230
if grid:
228231
command += [

0 commit comments

Comments
 (0)