blacklist audio keyword not working

[jojofofo36]

hello, for a movie with 2 audio tracks, one titled TrueHD 5.1and one titled AC-3 5.1, in the settings i blacklisted the keyword truehd because i want ac3 audio track but its not working, the movie keep defaulting to truehd, is there any setting i need to change ? the truehd track is also listed as default.
Thanks

[rockrider69]

Hello @jojofofo36 and thx for reporting here !
As you describe the case this should definitely work.
This is assuming both tracks being eligible via your preferences via their language name of course ;). The default flag is irrelevant to LPM unless its finds no match at all for your audio preferences: only then it is back to KODI and the default one.

Could you run KODI and LPM both in debug more, launch you movie and send me a link to the resulting kodi.log file (use https://paste.kodi.tv/)
Also a copy or link to your settings.xml and a mediainfo output of the movie file will help.
Thx in advance !

[jojofofo36]

ok so i did some tests and the blacklist feature only works when the audio languages preference is met, and it is only working when the audio language is not from the original language list

exemple : movie with english tagged in both track as original audio, with 2 tracks : first one named dts and second one named dolby

if i blacklist dts and have english in the audio preference, it works and do not choose the dts track

if i blacklist dts and have none in the audio preference, it will ignore blacklist

if i blacklist dts and have english in the audio preference AND have eng in the original language preference, it will ignore blacklist and play the first track i guess default so dts

can i suggest to always have blacklist keyword active ? maybe as an optional toggle ?

[rockrider69]

yes your tests are correct and you got it right how this is supposed to work now !

The original audio preference option is one I added a couple of releases ago, but indeed it is evaluated before even looking at the blacklist or other audio preferences. Clearly I wrongly assumed that there would normally not be more than 1 "original language" track in a movie...

Your 3rd case with "eng TrueHD" and "eng AC3" and "both tracks tagged isorigina" and "eng in original list" : this is 100% relevant so I'll have to fix that in the future release, probably always execute blacklist evaluation first, so that you get eng AC3 if trueHD is blacklisted.

Your second case though (no audio preference and blacklist dts) : I prefer not change that to keep the main principal that if the main audio preference menu is not active in the addon, then LPM should be transparent for audio and it is strictly back to KODI default selection logic.

Thx for reporting that !

[jojofofo36]

i did my own addon to popup the audio track menu when the playback is started so i can choose which track i want easy, here is the code if one day you want to add this option to your addon ☺ :

import xbmc
import xbmcgui
import json

def onAVStarted(self):
xbmc.log("Audio Selector: Movie started, waiting 2s", xbmc.LOGINFO)
xbmc.sleep(2000)

# Retrieve active player id
rpc = json.loads(xbmc.executeJSONRPC(
    '{"jsonrpc":"2.0","method":"Player.GetActivePlayers","id":1}'
))

if not rpc.get("result"):
    return

playerid = rpc["result"][0]["playerid"]

# Get all audio tracks
rpc = json.loads(xbmc.executeJSONRPC(f'''
{{
  "jsonrpc": "2.0",
  "method": "Player.GetProperties",
  "params": {{
    "playerid": {playerid},
    "properties": ["audiostreams", "currentaudiostream"]
  }},
  "id": 1
}}
'''))

streams = rpc["result"]["audiostreams"]
current = rpc["result"]["currentaudiostream"]

labels = []
indices = []

for i, s in enumerate(streams):
    lang = s.get("language", "und").upper()
    codec = s.get("codec", "").upper()
    channels = s.get("channels", 0)
    name = s.get("name", "")

    label = lang
    if name:
        label += f" · {name}"
    if codec:
        label += f" · {codec}"
    if channels:
        label += f" · {channels}ch"

    # Label the active track
    if s == current:
        label = ">> " + label

    labels.append(label)
    indices.append(i)

dialog = xbmcgui.Dialog()
choice = dialog.select("Choose the audio track", labels)

if choice >= 0:
    xbmc.executeJSONRPC(f'''
    {{
      "jsonrpc": "2.0",
      "method": "Player.SetAudioStream",
      "params": {{
        "playerid": {playerid},
        "stream": {indices[choice]}
      }},
      "id": 1
    }}
    ''')

[rockrider69]

Thanks! nice code proposal, I might think about this kind of "interactive" option in the future.

About your initial issue, can you please check if branch 1.0.9Beta2 is doing the trick, ie respecting blacklisting also for original tracks selection ?