Skip to content

Support dispatching make-release-artifacts workflow manually #18

@TwitchBronBron

Description

@TwitchBronBron

Add support for dispatching the make-release-artifacts workflow manually.

In rare cases, make-release-artifacts might not be working as expected, or it fails, but somehow the github release is still created. This causes a situation where we can no longer produce new build artifacts, but we also can't publish to npm or vscode marketplace with the publish-release because there are no artifacts. (like in this recent build failure).

To mitigate that, I had to manually build the artifact locally and upload it to the release, then rerun publish-release. I'd like to avoid needing to do this.

Considerations:

  • we really don't want to support rerunning the job if npm or vscode marketplace already has the artifacts. That could result in a situation where the published artifact is different than the published version.
    • a cool extra feature could be that, if somehow someone deleted the release artifact, but we're published to npm, we could re-download the file from npm and put it on the release
  • criteria would need to include:
    • version (i.e. the release name)
    • what git ref to use to build the release (because it probably shouldn't be master in case we've merged new code since then

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions