From 21e5c4addcc8cf45a6736a048a2378eea2f42f73 Mon Sep 17 00:00:00 2001 From: Sattvik Kansal Date: Mon, 27 Apr 2026 13:24:58 -0700 Subject: [PATCH] chore: drop unused sha3 dep (supersedes #24) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The sha3 crate has been declared in both Cargo.toml files since the upstream SputnikVM fork, but is not actually used: SHA3 opcode handling in runtime/src/eval/system.rs delegates to Handler::keccak256_h256(), not sha3::Keccak256. The crate is not re-exported by lib.rs, and grepping rome-evm-private/rome-sdk/rome-apps confirms no downstream consumer pulls it through the evm crate. Dropping the dep cleanly resolves dependabot #24 (sha3 0.8 → 0.11), which fails because sha3 0.10+ removed the `std` feature flag that both Cargo.toml files reference under their `std` feature. Verified: - RUSTFLAGS=-Aunexpected_cfgs cargo build --release — succeeds - RUSTFLAGS=-Aunexpected_cfgs cargo clippy — clean - RUSTFLAGS=-Aunexpected_cfgs cargo test — 0 tests (none defined) - rome-evm-private/rome-sdk/rome-apps grep — no direct sha3 imports through the evm crate, so no downstream rebuild needed Co-Authored-By: Claude Opus 4.7 (1M context) --- Cargo.toml | 3 +-- runtime/Cargo.toml | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index ab7fba2..4f488d1 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -12,7 +12,6 @@ edition = "2018" log = { version = "0.4", default-features = false } evm-core = { version = "0.18", path = "core", default-features = false, features = ["with-serde"] } evm-runtime = { version = "0.18", path = "runtime", default-features = false } -sha3 = { version = "0.8", default-features = false } rlp = { version = "0.6", default-features = false } serde = { version = "1.0", default-features = false, features = ["derive"], optional = true } serde_bytes = { version = "0.11.5", optional = true } @@ -22,4 +21,4 @@ codec = { package = "parity-scale-codec", version = "1.3", default-features = fa default = ["std"] with-codec = ["codec", "evm-core/with-codec", "evm-runtime/with-codec"] with-serde = ["serde", "serde_bytes", "evm-core/with-serde", "evm-runtime/with-serde"] -std = ["evm-core/std", "evm-runtime/std", "sha3/std", "serde/std", "codec/std", "log/std"] +std = ["evm-core/std", "evm-runtime/std", "serde/std", "codec/std", "log/std"] diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml index c6a806a..88e6108 100644 --- a/runtime/Cargo.toml +++ b/runtime/Cargo.toml @@ -10,7 +10,6 @@ edition = "2018" [dependencies] evm-core = { version = "0.18", path = "../core", default-features = false } -sha3 = { version = "0.8", default-features = false } codec = { package = "parity-scale-codec", version = "1.3", default-features = false, features = ["derive", "full"], optional = true } serde = { version = "1.0", default-features = false, features = ["derive"], optional = true } serde_bytes = { version = "0.11.5", optional = true } @@ -20,4 +19,4 @@ borsh = { version = "1.5.3", features = ["derive", "unstable__schema"] } default = ["std"] with-codec = ["codec"] with-serde = ["serde", "serde_bytes"] -std = ["evm-core/std", "sha3/std"] +std = ["evm-core/std"]