From a62643404bdc5a81420f457cef343779a68bbfb5 Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 24 Apr 2026 15:39:05 +0200 Subject: [PATCH 1/3] [RF] fix windows warning C:\ROOT-CI\src\roofit\roofitcore\src\RooLinkedList.cxx(71,19): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\ROOT-CI\build\roofit\roofitcore\RooFitCore.vcxproj] --- roofit/roofitcore/src/RooLinkedList.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roofit/roofitcore/src/RooLinkedList.cxx b/roofit/roofitcore/src/RooLinkedList.cxx index a0989358f33d8..accb045a5b4ce 100644 --- a/roofit/roofitcore/src/RooLinkedList.cxx +++ b/roofit/roofitcore/src/RooLinkedList.cxx @@ -68,7 +68,7 @@ namespace RooLinkedListImplDetails { ~Chunk() { delete[] _chunk; } /// chunk capacity Int_t capacity() const - { return (1 << _sz) / sizeof(RooLinkedListElem); } + { return (1L << _sz) / sizeof(RooLinkedListElem); } /// chunk free elements Int_t free() const { return _free; } /// chunk occupied elements From deafca7652982c72a837e85d16f3bd710d4b069d Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 24 Apr 2026 15:41:24 +0200 Subject: [PATCH 2/3] [core] fix unused var warning --- core/base/src/TROOT.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/core/base/src/TROOT.cxx b/core/base/src/TROOT.cxx index 85edbf60201a8..0ad84cf5c6a37 100644 --- a/core/base/src/TROOT.cxx +++ b/core/base/src/TROOT.cxx @@ -340,6 +340,7 @@ namespace { try { desiredValue = std::stoi(env); } catch (std::invalid_argument &e) { + (void)e; Error("TROOT", "%s should be 0 or 1", envName); } if (desiredValue == 0) { From ee38df8c0c62438745979cc2179dd8b7a99e76df Mon Sep 17 00:00:00 2001 From: ferdymercury Date: Fri, 24 Apr 2026 17:32:13 +0200 Subject: [PATCH 3/3] Update RooLinkedList.cxx --- roofit/roofitcore/src/RooLinkedList.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roofit/roofitcore/src/RooLinkedList.cxx b/roofit/roofitcore/src/RooLinkedList.cxx index accb045a5b4ce..a16a26044c9d2 100644 --- a/roofit/roofitcore/src/RooLinkedList.cxx +++ b/roofit/roofitcore/src/RooLinkedList.cxx @@ -68,7 +68,7 @@ namespace RooLinkedListImplDetails { ~Chunk() { delete[] _chunk; } /// chunk capacity Int_t capacity() const - { return (1L << _sz) / sizeof(RooLinkedListElem); } + { return (1ULL << _sz) / sizeof(RooLinkedListElem); } /// chunk free elements Int_t free() const { return _free; } /// chunk occupied elements