Skip to content

The TCL lexer is real bad #2312

Description

@jneen

So much overly clever programming that doesn't even work... did anyone test this? Who wrote thi-

oh. it was me. in 2013.

Well I suppose I ought to give it an overhaul then.

Issues:

  • Gives up too eagerly on highlighting within {} (yes it's technically a string literal that's very nice but it's also like... code most of the time)
  • Keyword detection is just completely broken, even at the top level
  • Root cause is this CHARS[...] and NOT_CHARS[...] lambda approach to regexes, which is extremely overeager and consumes all whitespace in front of it. Those helpers should be deleted in favour of just inlining those regexes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugfix-requestA request for a bugfix to be developed.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions