From ced2d473391dfde32e15e7d4eb5530aac34ef04a Mon Sep 17 00:00:00 2001
From: Abhishek Hiremath <131762197+Abhi-DevHub@users.noreply.github.com>
Date: Thu, 16 Jul 2026 22:56:19 +0530
Subject: [PATCH] fix(go): report failure when build produces unrecognized
 error output

filter_go_build_with_exit() determined success purely by scanning for
known error patterns. When go build failed with an error that didn't
match any pattern (e.g. 'stat ...: directory not found'), unrecognized
output lines fell through silently and the filter returned 'Success'
despite the presence of non-download, non-progress output text.

A successful go build produces no output or only download/progress lines.
Any other unrecognized output is now treated as a failure - the raw
output is preserved through format_go_build_failure so the actual error
remains visible.

Fixes #1599

Signed-off-by: Abhi-DevHub <abhishekkumar@duck.com>
---
 src/cmds/go/go_cmd.rs | 45 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/src/cmds/go/go_cmd.rs b/src/cmds/go/go_cmd.rs
index d35399bbcc..b2c10c7f28 100644
--- a/src/cmds/go/go_cmd.rs
+++ b/src/cmds/go/go_cmd.rs
@@ -575,6 +575,23 @@ pub(crate) fn filter_go_build(output: &str) -> String {
     filter_go_build_with_exit(output, 0)
 }
 
+fn has_unrecognized_output(output: &str) -> bool {
+    output.lines().any(|l| {
+        let t = l.trim();
+        if t.is_empty() || t.starts_with('#') {
+            return false;
+        }
+        let lower = t.to_lowercase();
+        if lower.starts_with("go: downloading ")
+            || lower.starts_with("go: finding ")
+            || lower.starts_with("go: extracting ")
+        {
+            return false;
+        }
+        !is_go_build_error_line(t)
+    })
+}
+
 fn filter_go_build_with_exit(output: &str, exit_code: i32) -> String {
     let mut errors: Vec<String> = Vec::new();
 
@@ -586,6 +603,9 @@ fn filter_go_build_with_exit(output: &str, exit_code: i32) -> String {
     }
 
     if errors.is_empty() {
+        if has_unrecognized_output(output) {
+            return format_go_build_failure(output, exit_code);
+        }
         return if exit_code == 0 {
             "Go build: Success".to_string()
         } else {
@@ -1052,6 +1072,31 @@ pattern ./...: directory prefix . does not contain modules listed in go.work or
         assert!(!result.contains("Success"));
     }
 
+    #[test]
+    fn test_filter_go_build_unrecognized_error_not_swallowed() {
+        let output = "stat /some/path/cmd/orator: directory not found\n";
+
+        let result = filter_go_build(output);
+        assert!(
+            result.contains("failed"),
+            "Should report failure, got: {}",
+            result
+        );
+        assert!(
+            result.contains("directory not found"),
+            "Should preserve raw error, got: {}",
+            result
+        );
+    }
+
+    #[test]
+    fn test_filter_go_build_download_lines_still_success() {
+        let output = "go: downloading github.com/foo/bar v1.0.0\n";
+
+        let result = filter_go_build(output);
+        assert!(result.contains("Success"));
+    }
+
     #[test]
     fn test_filter_go_vet_no_issues() {
         let output = "";