Add --sig and --no-sig flag for RBS signatures#9561
Open
packrat386 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I do not tend to use RBS signatures, so when I create a new gem I would like the option to not generate them in the first place.
What is your fix for the problem, implemented in this PR?
This adds
--sigand--no-sigso the user can specify whether or not they want signatures. The default is enabled so nothing changes for anybody used the existing behavior unless they opt in.I understand based on discussion in #5041 that this was deemed unnecessary (specifically #5041 (comment)), but I think that after a few years of having RBS signatures available it seems that usage is not so universal as to justify having no opt out (besides deleting the files). I didn't add any persistent config to make
--no-siga system default since it seems like we probably like having the nudge towards using RBS signatures by default, but at least in my own use ofbundle gemI would appreciate being able to turn it off.Make sure the following tasks are checked