Add settings checkbox(es) for removing context menu items for link and selected text

[h-h-h-h]

Installing various add-ons can easily clutter up the context menu, even if some items are just present when text is selected.

Please add a checkbox as: [x] Show context menu item for selected text. You can keep the current default.

I think, when the following already present checkbox is checked: [x] Automatically use the text selected on the website, the new checkbox should be disabled and unchecked.

[rugk]

You know that one only sees the context menu item if text is selected and/or if you click on a link?

So it's at least not shown for all cases.
And thus, IMHO, quite discrete…

---

That said, I would be fine with such a checkbox (enabled by default, as you said). (PRs appreciated…)

I am not fine with automatically disabling/modifying it when another option is changed though. The correlation between the settings may not obvious to the user and there are valid use-cases for having both settings enabled.

[shanirub]

Hi there, I would like to work on this issue.

The task as i understand it includes the following steps:

1. Edit options.html, so that the new checkbox will be displayed.
2. Edit DefaultSettings.js, so that this option will be enabled as default (as rugk requested).
3. Edit messages.json files for each language (or maybe this should come afterwards, as a different task?).
4. Edit InitQrCode.js: write the logic behind this option.

As a beginner i would love to get some feedback:
Did i forget anything? Any advice?
Thanks.

[rugk]

Hi @shanirub ,
great, yes, feel free to take this issue. 😃

1. Yep. For help see the module doc for settings: https://github.com/TinyWebEx/AutomaticSettings
2. Yep, exactly.
3. When you do this hardly matters, but yes, the new options should be localized. Again module doc: https://github.com/TinyWebEx/Localizer (Of course, you can only translate it for the languages you speak by yourself.)
4. Well..., no. The real pointer for you would be https://github.com/rugk/offline-qr-code/blob/master/src/background/modules/ContextMenu.js

[shanirub]

• Displaying option as a check box.
  options.html
• Implementing the logic.
  ContextMenu.js
• Option should be enabled as default.
  DefaultSettings.js
• Updating localization.

[c3ho]

Hi, I noticed this hasn't been updated since July 22. May I work on the issue?
I'm a first time contributor, so please bear with me.

[rugk]

@shanirub already did some work on this, as it seems. So let's wait for a reply here.
Having a quick look at the fork, the changes are apparently in the master branch here: https://github.com/shanirub/offline-qr-code/commits/master (not reviewed!)

So assigning @shanirub for getting a reply whether @c3ho can/should take over this change or not?

[shanirub]

@rugk I would very much like to continue working on this issue.
@c3ho sorry.

[jn64]

Hope to see this feature, because Firefox default access key for Inspect Element is also Q.

Alternatively allow changing the access key for this addon to R

[rugk]

Alternatively allow changing the access key for this addon to R

For simplicity reasons, we'd only want to have one fixed and value and it should be a word that is included in the context menu text. In any case, however, your underlying issue seems to be valid/a good point, so please open a new issue for that. (As it may be fixed independently to this one, as you've noticed by yourself.)

[rugk]

@shanirub If you need any pointers/help or have questions, feel free to ask.