From e6c373713af36d5d1b9d7f757aaf86b6a39268ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20=28Dibildos=29=20Gonz=C3=A1lez?= Date: Mon, 1 Dec 2025 17:44:01 +0100 Subject: [PATCH 1/3] refactor: rename function to Convert-NotesMeetingMembersToMarkdown --- public/convertMeetingMembersToMarkdown.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/public/convertMeetingMembersToMarkdown.ps1 b/public/convertMeetingMembersToMarkdown.ps1 index 5a22777..0a72ce3 100644 --- a/public/convertMeetingMembersToMarkdown.ps1 +++ b/public/convertMeetingMembersToMarkdown.ps1 @@ -1,5 +1,5 @@ -function Convert-MeetingMembersToMarkdown { +function Convert-NotesMeetingMembersToMarkdown { [CmdletBinding()] param( [Parameter(Position = 0, ValueFromPipeline)][string]$MeetingMembers @@ -55,4 +55,4 @@ function Convert-MeetingMembersToMarkdown { return $result } -} Export-ModuleMember -Function 'Convert-MeetingMembersToMarkdown' +} Export-ModuleMember -Function 'Convert-NotesMeetingMembersToMarkdown' From 4987f65bc3c219dd33beb09c52a4f28766aad209 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20=28Dibildos=29=20Gonz=C3=A1lez?= Date: Mon, 1 Dec 2025 17:44:13 +0100 Subject: [PATCH 2/3] refactor: add member count to company header in groupMembersByCompany --- private/parseMemberEmail.ps1 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/private/parseMemberEmail.ps1 b/private/parseMemberEmail.ps1 index c0a3509..35f110b 100644 --- a/private/parseMemberEmail.ps1 +++ b/private/parseMemberEmail.ps1 @@ -68,8 +68,9 @@ function groupMembersByCompany { $result = @() foreach ($group in $grouped) { - # Add company header - $result += "- $($group.Name)" + # Add company header with member count + $memberCount = $group.Group.Count + $result += "- $($group.Name) ($memberCount)" # Add members with 4-space indentation foreach ($member in $group.Group) { From 412e2be4f38403f40f416e947397fd6756eeb840 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20=28Dibildos=29=20Gonz=C3=A1lez?= Date: Mon, 1 Dec 2025 17:44:20 +0100 Subject: [PATCH 3/3] test: update tests to use Convert-NotesMeetingMembersToMarkdown function --- .../convertMeetingMembersToMarkdown.test.ps1 | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/Test/public/convertMeetingMembersToMarkdown.test.ps1 b/Test/public/convertMeetingMembersToMarkdown.test.ps1 index 22bf1c8..87ccc46 100644 --- a/Test/public/convertMeetingMembersToMarkdown.test.ps1 +++ b/Test/public/convertMeetingMembersToMarkdown.test.ps1 @@ -4,11 +4,11 @@ function Test_ConvertMeetingMembersToMarkdown_SingleCompany { $input = "Alice Johnson , `"Bob Smith (AlphaTech)`" " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert $expected = @" -- Alphatech +- Alphatech (2) - Alice Johnson - "Bob Smith (AlphaTech)" "@ @@ -21,16 +21,16 @@ function Test_ConvertMeetingMembersToMarkdown_MultipleCompanies { $input = "Alice Johnson , `"Bob Smith (AlphaTech)`" , Alice Johnson , `"Charlie Brown, David`" , `"Emma Wilson, Frank`" , `"Grace Lee, Henry`" " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert $expected = @" -- Alphatech +- Alphatech (2) - Alice Johnson - "Bob Smith (AlphaTech)" -- Betasoft +- Betasoft (1) - Alice Johnson -- Gammatech +- Gammatech (3) - "Charlie Brown, David" - "Emma Wilson, Frank" - "Grace Lee, Henry" @@ -44,14 +44,14 @@ function Test_ConvertMeetingMembersToMarkdown_DuplicateMemberDifferentCompanies $input = "Alice Johnson , Alice Johnson " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert # Same person with different emails should appear in both company groups $expected = @" -- Alphatech +- Alphatech (1) - Alice Johnson -- Betasoft +- Betasoft (1) - Alice Johnson "@ Assert-AreEqual -Expected $expected -Presented $result -Comment "Same person with different emails should appear in both companies" @@ -63,14 +63,14 @@ function Test_ConvertMeetingMembersToMarkdown_SpecialCharactersInName { $input = "`"Bob Smith (AlphaTech)`" , `"Charlie Brown, David`" " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert # Names with special characters (parentheses, commas) should be preserved $expected = @" -- Alphatech +- Alphatech (1) - "Bob Smith (AlphaTech)" -- Gammatech +- Gammatech (1) - "Charlie Brown, David" "@ Assert-AreEqual -Expected $expected -Presented $result -Comment "Names with special characters should be preserved" @@ -82,7 +82,7 @@ function Test_ConvertMeetingMembersToMarkdown_EmptyInput { $input = "" # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert Assert-AreEqual -Expected "" -Presented $result -Comment "Empty input should return empty string" @@ -94,7 +94,7 @@ function Test_ConvertMeetingMembersToMarkdown_WhitespaceOnlyInput { $input = " " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert Assert-AreEqual -Expected "" -Presented $result -Comment "Whitespace-only input should return empty string" @@ -106,11 +106,11 @@ function Test_ConvertMeetingMembersToMarkdown_SingleMember { $input = "John Doe " # Act - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $input + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $input # Assert $expected = @" -- Example +- Example (1) - John Doe "@ Assert-AreEqual -Expected $expected -Presented $result -Comment "Single member should work correctly" @@ -122,16 +122,16 @@ function Test_ConvertMeetingsMembersToMarkdown_Big_sample{ "Alice Anderson" , "Amy Adams (She/Her)" , "Bob Brown" , "Charlie Chen" , david.davis@betasoft.com, "David Dennis" , "Emma Evans, Eric" , emma.edwards@betasoft.com, "Frank Fields, Fiona" , george.garcia@bookings.betasoft.com, george.garcia@betasoft.com, "Grace (AlphaTech) Garcia" , "Henry Harris" , "Iris Ingram" , "Jack Johnson" , "James Jackson" , "Jennifer Jones" , "Kevin Kim" , "Kyle Knight" , lisa.lee@betasoft.com, "Laura Lewis" , "Mark Martinez" "@ - $result = Convert-MeetingMembersToMarkdown -MeetingMembers $imput + $result = Convert-NotesMeetingMembersToMarkdown -MeetingMembers $imput Assert-AreEqual -Presented $result -Expected @" -- Alphatech +- Alphatech (5) - "Grace (AlphaTech) Garcia" - "Henry Harris" - "Kevin Kim" - "Laura Lewis" - "Mark Martinez" -- Betasoft +- Betasoft (9) - "Amy Adams (She/Her)" - "Bob Brown" - "Charlie Chen" @@ -141,7 +141,7 @@ function Test_ConvertMeetingsMembersToMarkdown_Big_sample{ - "James Jackson" - "Jennifer Jones" - "Kyle Knight" -- Deltalab +- Deltalab (3) - "Alice Anderson" - "Emma Evans, Eric" - "Frank Fields, Fiona"