Skip to content

"Suicide" bunker kills don't always work #42

@sam-mfb

Description

@sam-mfb

When you crash into a bunker, it doesn't always kill the bunker.

Clip from the original game to show this was there in the original:

proximity-bug.mp4

This basically results from this constant (GW.h:90)

#define	SKILLBRADIUS 30		/* for computing suicide kills	*/

The problem is that you can have collisions with bunkers that don't fall within the radius. For example, on Level 2

{inKillRadius: true, bunkerX: 407, bunkerY: 419, shipX: 389, shipY: 397} 

{inKillRadius: false, bunkerX: 407, bunkerY: 419, shipX: 386, shipY: 393} 

Both of these are actual collisions with the bunker (which is determined by pixel overlap not radius), but the second one falls outside the 30px radius. sqrt(21^2 + 26^2) = 33.4

This tends to happen either when you are moving slowly so the collision frame is right on the edge. Bit can also happen when you just have bad luck and your thrusting lands you right on the edge.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug in originalA bug that existed in the original game

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions