If we're not careful about documenting certain features, we might trigger unexpected behavior.
In particular, one could argue that converting a literal to a token in a certain rule means that skip will be run before and after the token. The original rule did not make use of skip. Therefore the mage_extract_literals pass changes the semantics of the grammar.
The previous bug can be documented into a feature. The question is whether this is desirable.
If we're not careful about documenting certain features, we might trigger unexpected behavior.
In particular, one could argue that converting a literal to a token in a certain rule means that
skipwill be run before and after the token. The original rule did not make use ofskip. Therefore themage_extract_literalspass changes the semantics of the grammar.The previous bug can be documented into a feature. The question is whether this is desirable.