fix(notifier): decouple immediate notifications from request context#776
Merged
Conversation
The immediate-notification gocron job captured the HTTP request context, which net/http cancels as soon as the handler returns. The async job then failed its DB lookup and Campfire send with "context canceled" every time. ScheduleImmediate no longer takes a caller context; gocron supplies a job-scoped context to the task at execution time, bounded by a 30s timeout. Subject rendering is split into its own embedded template, and the MIME type for outbound mail is configurable. Also tightens service-endpoint:read-global to cloud_admin in policy.json.
notandy
requested review from
a team,
m-kratochvil,
notque and
ronchi-oss
as code owners
notque
approved these changes
May 20, 2026
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The immediate-notification gocron job captured the HTTP request context, which net/http cancels the moment the handler returns. The async DB lookup and Campfire send then failed with
context canceledevery time.ScheduleImmediateno longer takes a caller context; gocron supplies a job-scoped context to the task at execution time, bounded by a 30s timeout.Subject rendering is split into its own embedded template; the outbound MIME type is now configurable.
Tightens
service-endpoint:read-globaltocloud_admininpolicy.json.