Skip to content

Goroutine leaks and silent TLS config fallback in arke Serve #88

Description

@miotte

A few issues in the server's Serve path:

  • listener() silently falls back to cleartext when tlsConfig returns an error, even though the operator asked for TLS. The error should be surfaced instead.
  • serveErrChan is unbuffered and the non-OpError branch does not return, leaving a sender blocked on shutdown and leaking the goroutine.
  • The signal-handler goroutine does not exit on context cancel and signal.Notify is never stopped, so goroutines accumulate across repeated Serve calls.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggoPull requests that update go code

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions