Skip to content

Bump external-content/cookie from 4d7762b to 228add5#319

Open
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/submodules/external-content/cookie-228add5
Open

Bump external-content/cookie from 4d7762b to 228add5#319
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/submodules/external-content/cookie-228add5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 9, 2026

Copy link
Copy Markdown
Contributor

Bumps external-content/cookie from 4d7762b to 228add5.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [external-content/cookie](https://github.com/scientific-python/cookie) from `4d7762b` to `228add5`.
- [Release notes](https://github.com/scientific-python/cookie/releases)
- [Commits](scientific-python/cookie@4d7762b...228add5)

---
updated-dependencies:
- dependency-name: external-content/cookie
  dependency-version: 228add5438e25e3357d0c3f9afc088ce48df25f4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jun 9, 2026
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for learn-scientific-python-org ready!

Name Link
🔨 Latest commit cff27e0
🔍 Latest deploy log https://app.netlify.com/projects/learn-scientific-python-org/deploys/6a27a268714b7a0008c7f81e
😎 Deploy Preview https://deploy-preview-319--learn-scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 97
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

henryiii added 3 commits June 8, 2026 23:57
Cookie moved its docs from Jekyll to MyST in scientific-python/cookie#792.
Build the development site with `myst build --html` (BASE_URL=/development)
and drop the obsolete ruby/jekyll and repo-review-app fetch steps.

Assisted-by: ClaudeCode:claude-opus-4.8
Use a trailing slash on BASE_URL so MyST joins it to root-relative
page links correctly (was producing /developmentpages/...), and bump
the cookie submodule to include the hyphenated-slug internal link fix
(scientific-python/cookie#796) so checklinks passes.

Assisted-by: ClaudeCode:claude-opus-4.8
netlify-plugin-checklinks (hyperlink) now traverses the full cookie
site and flags two non-issues: its parser fails on MyST's bundled
mermaid chunk, and it reports valid in-page fragments as broken when
the target goes through MyST pretty-URL normalization. Mark both as
todoPatterns so real broken links still fail the build.

Assisted-by: ClaudeCode:claude-opus-4.8
@henryiii

henryiii commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 AI text below 🤖

CI is green. Deploy Preview ready! and all checks pass (the "skipping" entries are Netlify's optional rules-changed checks, not failures).

Done — CI fixed

The deploy preview now builds and passes link-checking: https://deploy-preview-319--learn-scientific-python-org.netlify.app

It took fixing three layers, since each was masking the next:

Commit Fix
f224b6b Swapped the Jekyll/Ruby make cookie target for myst build --html; dropped the dead repo-review-app fetch and the now-broken .ruby-version symlink; added NODE_VERSION to netlify.toml.
d3ebd34 BASE_URL=/development/ (trailing slash — without it MyST emitted /developmentpages/...); bumped the cookie submodule to include the upstream link fix.
cff27e0 todoPatterns in netlify.toml so netlify-plugin-checklinks tolerates two unavoidable hyperlink artifacts (its parser choking on MyST's bundled mermaid chunk, and valid fragments flagged as broken through MyST's pretty-URL normalization).

Plus the upstream cookie fix you merged (#796): the guide's internal links used underscore filenames (packaging_simple) that didn't match MyST's hyphenated output slugs (packaging-simple).

To verify before pushing, I reproduced netlify-plugin-checklinks's exact hyperlink invocation locally (internalOnly: true, pretty: true) and confirmed it went from FAIL: 4 to FAIL: 0 — every real link still checked, only the 4 false positives demoted to TODO.

One note worth flagging: cookie's docs have a number of genuinely-broken external links (404s on docs.github.com, hatch.pypi.io, pipx, etc.). They don't affect this build because checkExternal defaults to off, but they're real rot in the guide if you ever want to chase them upstream.

@dependabot @github

dependabot Bot commented on behalf of github Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

A newer version of external-content/cookie exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant