From 69ca3ec8e427fe172bd748f2137aff33ec9b97ec Mon Sep 17 00:00:00 2001 From: Michael Grosse Huelsewiesche Date: Thu, 5 Mar 2026 14:07:36 -0500 Subject: [PATCH 1/2] Add settings suite to browser e2e-cli config, update CI workflow - Add settings to test_suites in e2e-config.json - Rename SETTINGS_ERROR_TOLERANCE -> SETTINGS_ERROR_FALLBACK - Skip e2e tests on fork PRs (no access to repo secrets) - Accept e2e_tests_ref input for cross-repo test validation Co-Authored-By: Claude Opus 4.6 --- .github/workflows/e2e-tests.yml | 10 +++++++++- packages/browser/e2e-cli/e2e-config.json | 5 +++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 31cdda235..6ae893390 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -13,10 +13,17 @@ on: branches: [main, master] pull_request: branches: [main, master] - workflow_dispatch: # Allow manual trigger + workflow_dispatch: + inputs: + e2e_tests_ref: + description: 'Branch or ref of sdk-e2e-tests to use' + required: false + default: 'main' jobs: e2e-tests: + # Skip on fork PRs where repo secrets aren't available + if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} runs-on: ubuntu-latest steps: @@ -29,6 +36,7 @@ jobs: uses: actions/checkout@v4 with: repository: segmentio/sdk-e2e-tests + ref: ${{ inputs.e2e_tests_ref || 'main' }} token: ${{ secrets.E2E_TESTS_TOKEN }} path: sdk-e2e-tests diff --git a/packages/browser/e2e-cli/e2e-config.json b/packages/browser/e2e-cli/e2e-config.json index 9d9061d0b..1e0b7ee77 100644 --- a/packages/browser/e2e-cli/e2e-config.json +++ b/packages/browser/e2e-cli/e2e-config.json @@ -1,9 +1,10 @@ { "sdk": "browser", - "test_suites": "basic", + "test_suites": "basic,retry,settings", "auto_settings": true, "patch": "analytics-browser-http.patch", "env": { - "BROWSER_BATCHING": "false" + "BROWSER_BATCHING": "false", + "SETTINGS_ERROR_FALLBACK": "false" } } From 48d84a349d35190b8a472bf66a418788af4614ea Mon Sep 17 00:00:00 2001 From: Michael Grosse Huelsewiesche Date: Fri, 13 Mar 2026 16:27:20 -0400 Subject: [PATCH 2/2] Remove 'retry' from test_suites in e2e-config --- packages/browser/e2e-cli/e2e-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/browser/e2e-cli/e2e-config.json b/packages/browser/e2e-cli/e2e-config.json index 1e0b7ee77..ae4146297 100644 --- a/packages/browser/e2e-cli/e2e-config.json +++ b/packages/browser/e2e-cli/e2e-config.json @@ -1,6 +1,6 @@ { "sdk": "browser", - "test_suites": "basic,retry,settings", + "test_suites": "basic,settings", "auto_settings": true, "patch": "analytics-browser-http.patch", "env": {