runtime nodejs12.x is not supported

[cscetbon]

On aws we use runtime nodejs12.x to use nodejs 12. However with kubeless we need to use nodejs12 instead. I think nodejs12.x should be accepted.

[andresmgot]

Hi @cscetbon,

The format of the serverless.yaml is not fully compatible with AWS so even if we support their naming of runtimes there will be other functionalities that won't work.

In any case, feel free to add suport to the .x naming in this repo, as long as we support both it shouldn't be an issue (note that kubeless core, will only understand node12, not node12.x so it should be translated before creating the Function object).

[cscetbon]

@andresmgot Can you point me where I should start ?

[andresmgot]

As far as I can see there are two places in which the runtime is being read (there might be more, it's a matter of trying):

• To read the configuration and match it to find the dependency file:

https://github.com/serverless/serverless-kubeless/blob/master/lib/helpers.js#L218

• To get the runtime definition:

https://github.com/serverless/serverless-kubeless/blob/master/lib/deploy.js#L105

I those two places you would need to transform nodejs12.x to nodejs12 (basically removing the suffix).