Merge most impl Device blocks in src/hardware_buffer#374
Merged
mrobinson merged 1 commit intoJun 9, 2026
Conversation
This change just moves code and adjust imports. It was very previously difficult to know where any particular `Device` method was implemented. This will also make it easier to eliminate `macros.rs, necessary to implement the new version of the API. The downside is that now much of the implementation is gathered into the `device.rs` files, but these usually do not go beyond 1500 lines. Further changes to the API will eliminate many lines of code and spread the logic more equally between files. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
jdm
approved these changes
Jun 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change just moves code and adjust imports. It was very previously
difficult to know where any particular
Devicemethod was implemented.This will also make it easier to eliminate
macros.rs, necessary toimplement the new version of the API. The downside is that now much of
the implementation is gathered into the
device.rsfiles, but theseusually do not go beyond 1500 lines. Further changes to the API will
eliminate many lines of code and spread the logic more equally between
files.
Signed-off-by: Martin Robinson mrobinson@igalia.com