Default ACLs lost when copying directories from /etc/skel

[ikerexxe]

Commit faeab50e replaced perm_copy_file() with perm_copy_path() wrapper that uses perm_copy_fd() underneath. perm_copy_file() copies both access + default ACLs. According to the libacl maintainer, perm_copy_fd() only copies access ACLs, thus loosing admin-configured ACL policies.

Possible fix

Revert perm_copy_path() back to perm_copy_file() for directories/special files, keeping perm_copy_fd() only for regular files.

Another possible fix

Migrate to gnulib modules and use get-permissions and set-permissions instead.

[andreas-gruenbacher]

This only affects directories as this is the only file type that can have default ACLs; special files are fine.

Another possible fix is to make perm_copy_fd() do the right thing and copy default ACLs as well.

[andreas-gruenbacher]

The next version of the acl package will include a fixed perm_copy_fd() function that also copies default ACLs.

[alejandro-colomar]

Cc: @cgzones

[alejandro-colomar]

Another possible fix

Migrate to gnulib modules and use get-permissions and set-permissions instead.

Unless we want to switch to the GPL-3 license (something I'd be happy with), we can't use gnulib.

[alejandro-colomar]

The next version of the acl package will include a fixed perm_copy_fd() function that also copies default ACLs.

Do you have an expected date for that?

[andreas-gruenbacher]

Around June 29 by today's plans.

[alejandro-colomar]

Then it will happen before our release, so I guess we don't need to worry at all then. Thanks! :)