Don't load ur10 kinematics_config without an arm#533
Closed
Jntzko wants to merge 1 commit intoshadow-robot:melodic-develfrom
Closed
Don't load ur10 kinematics_config without an arm#533Jntzko wants to merge 1 commit intoshadow-robot:melodic-develfrom
Jntzko wants to merge 1 commit intoshadow-robot:melodic-develfrom
Conversation
The ur10 kinematics config should not be loaded if the shadow hand is used without an arm. Without this patch we need a custom ur_description package in your workspace even if you don't use it.
Contributor
Author
|
Yes, this PR satisfies my requirements, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The ur10 kinematics config should not be loaded if the shadow hand is used without an arm.
Without this patch you need a custom ur_description package in your workspace even if you don't use it.
Types of changes
Checklist

@v4hn