Morph#22
Open
nicolawern wants to merge 12 commits into
Open
Conversation
| % Reserve the trajectory | ||
| %timerVal = tic; | ||
| [ok, res_ids, res_toa_s] = ... | ||
| obj.lbsd.reserveLBSDTrajectory(lane_ids, uas_i.id, toa_s, ... |
Owner
There was a problem hiding this comment.
@nicolawern I think this code is still calling my reservation method, should it be commented out?
Collaborator
Author
There was a problem hiding this comment.
It is still using your reservations which through all my tests produced the same result - I ran out of time to modify the reservations struct Tom uses to overwrite yours so I was just using a check to verify they were the same. Happy to work on this now
| end | ||
| % Generate a random request time | ||
|
|
||
| %I dont think request time is possible in rogue - this |
shortwavedave
requested changes
Jul 18, 2022
| %todo will flight plan be empty if can't be scheduled? | ||
| %when I was running Tom's code it would throw and error and | ||
| %break | ||
| if ~isempty(flight_plan) |
Owner
There was a problem hiding this comment.
Ideally all this stuff would be in the LBSD class so we can call reserveLBSDTrajectoryTch (or something like that) and it will have the same signature as reserveLBSDTrajectory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding rogue deconfliction