From 99f7905ad6b9e82375f2f89d7c394dc5515126b4 Mon Sep 17 00:00:00 2001 From: Alex Luck Date: Fri, 26 Sep 2025 09:14:26 -0700 Subject: [PATCH 1/2] remove default logger configuration to leave to implementation --- python/lib/sift_client/__init__.py | 9 +-------- .../sift_client/_internal/low_level_wrappers/assets.py | 4 ---- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/python/lib/sift_client/__init__.py b/python/lib/sift_client/__init__.py index 49bdc04d9..61912cb86 100644 --- a/python/lib/sift_client/__init__.py +++ b/python/lib/sift_client/__init__.py @@ -213,11 +213,4 @@ async def get_asset_async(): "SiftConnectionConfig", ] -logger = logging.getLogger("sift_client") -logging.basicConfig( - level=logging.ERROR, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s" -) - - -handler = logging.StreamHandler(sys.stdout) -logger.addHandler(handler) +logging.getLogger(__name__).addHandler(logging.NullHandler()) diff --git a/python/lib/sift_client/_internal/low_level_wrappers/assets.py b/python/lib/sift_client/_internal/low_level_wrappers/assets.py index c6c2fdb86..cede17db9 100644 --- a/python/lib/sift_client/_internal/low_level_wrappers/assets.py +++ b/python/lib/sift_client/_internal/low_level_wrappers/assets.py @@ -1,6 +1,5 @@ from __future__ import annotations -import logging from typing import Any, cast from sift.assets.v1.assets_pb2 import ( @@ -20,9 +19,6 @@ from sift_client.sift_types.asset import Asset, AssetUpdate from sift_client.transport import GrpcClient, WithGrpcClient -# Configure logging -logger = logging.getLogger(__name__) - class AssetsLowLevelClient(LowLevelClientBase, WithGrpcClient): """Low-level client for the AssetsAPI. From 221e3c8f20976c1faea98a02bc6151042256c34f Mon Sep 17 00:00:00 2001 From: Alex Luck Date: Fri, 26 Sep 2025 09:42:01 -0700 Subject: [PATCH 2/2] lint --- python/lib/sift_client/__init__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/python/lib/sift_client/__init__.py b/python/lib/sift_client/__init__.py index 61912cb86..5bcf1f5c3 100644 --- a/python/lib/sift_client/__init__.py +++ b/python/lib/sift_client/__init__.py @@ -203,7 +203,6 @@ async def get_asset_async(): """ import logging -import sys from sift_client.client import SiftClient from sift_client.transport import SiftConnectionConfig