tidy

Author: simbo1905

README.md

@@ -46,6 +46,9 @@ JsonValue backToJson = Json.fromUntyped(Map.of(
     "age", user.age(),
     "active", user.active()
 ));
+
+// Covert back to a JSON string
+String jsonString = backToJson.toString();
 ```
 
 ## Backport Project Goals
@@ -74,8 +77,8 @@ The original proposal and design rationale can be found in the included PDF: [To
 ## Modifications
 
 This is a simplified backport with the following changes from the original:
-- Replaced StableValue with double-checked locking pattern.
-- Removed value-based class annotations.
+- Replaced `StableValue.of()` with double-checked locking pattern.
+- Removed `@ValueBased` annotations.
 - Compatible with JDK 21.
 
 ## Security Considerations

json-compatibility-suite/src/main/java/jdk/sandbox/compatibility/JsonTestSuiteSummary.java

@@ -34,6 +34,7 @@ public static void main(String[] args) throws Exception {
     }
 
     void generateConformanceReport() throws Exception {
+        LOGGER.fine(() -> "Starting conformance report generation");
         TestResults results = runTests();
 
         System.out.println("\n=== JSON Test Suite Conformance Report ===");
@@ -59,11 +60,13 @@ void generateConformanceReport() throws Exception {
         System.out.printf("Overall Conformance: %.1f%%%n", conformance);
 
         if (!results.shouldPassButFailed.isEmpty()) {
+            LOGGER.fine(() -> "Valid JSON that failed to parse count=" + results.shouldPassButFailed.size());
             System.out.println("\n⚠️  Valid JSON that failed to parse:");
             results.shouldPassButFailed.forEach(f -> System.out.println("  - " + f));
         }
-        
+
         if (!results.shouldFailButPassed.isEmpty()) {
+            LOGGER.fine(() -> "Invalid JSON that was incorrectly accepted count=" + results.shouldFailButPassed.size());
             System.out.println("\n⚠️  Invalid JSON that was incorrectly accepted:");
             results.shouldFailButPassed.forEach(f -> System.out.println("  - " + f));
         }
@@ -74,12 +77,14 @@ void generateConformanceReport() throws Exception {
     }
 
     void generateJsonReport() throws Exception {
+        LOGGER.fine(() -> "Starting JSON report generation");
         TestResults results = runTests();
         JsonObject report = createJsonReport(results);
         System.out.println(Json.toDisplayString(report, 2));
     }
 
     private TestResults runTests() throws Exception {
+        LOGGER.fine(() -> "Walking test files under: " + TEST_DIR.toAbsolutePath());
         if (!Files.exists(TEST_DIR)) {
             throw new RuntimeException("Test suite not downloaded. Run: ./mvnw clean compile generate-test-resources -pl json-compatibility-suite");
         }
@@ -92,31 +97,39 @@ private TestResults runTests() throws Exception {
         int nPass = 0, nFail = 0;
         int iAccept = 0, iReject = 0;
 
-        var files = Files.walk(TEST_DIR)
-            .filter(p -> p.toString().endsWith(".json"))
-            .sorted()
-            .toList();
+        List<Path> files;
+        try (var stream = Files.walk(TEST_DIR)) {
+            files = stream
+                .filter(p -> p.toString().endsWith(".json"))
+                .sorted()
+                .toList();
+        }
+        LOGGER.fine(() -> "Discovered JSON test files: " + files.size());
 
         for (Path file : files) {
             String filename = file.getFileName().toString();
-            String content = null;
-            char[] charContent = null;
+            String content;
+            char[] charContent;
+            final Path filePathForLog = file;
+            LOGGER.fine(() -> "Processing file: " + filePathForLog);
 
             try {
                 content = Files.readString(file, StandardCharsets.UTF_8);
                 charContent = content.toCharArray();
             } catch (MalformedInputException e) {
-                LOGGER.warning("UTF-8 failed for " + filename + ", using robust encoding detection");
+                LOGGER.finer(()->"UTF-8 failed for " + filename + ", using robust encoding detection");
                 try {
                     byte[] rawBytes = Files.readAllBytes(file);
                     charContent = RobustCharDecoder.decodeToChars(rawBytes, filename);
                 } catch (Exception ex) {
-                    throw new RuntimeException("Failed to read test file " + filename + " - this is a fundamental I/O failure, not an encoding issue: " + ex.getMessage(), ex);
+                    skippedFiles.add(filename);
+                    LOGGER.fine(() -> "Skipping unreadable file: " + filename + " due to: " + ex.getClass().getSimpleName() + ": " + ex.getMessage());
+                    continue;
                 }
             }
 
             // Test with char[] API (always available)
-            boolean parseSucceeded = false;
+            boolean parseSucceeded;
             try {
                 Json.parse(charContent);
                 parseSucceeded = true;
@@ -126,6 +139,8 @@ private TestResults runTests() throws Exception {
                 LOGGER.warning("StackOverflowError on file: " + filename);
                 parseSucceeded = false; // Treat as parse failure
             }
+            final boolean parseResultForLog = parseSucceeded;
+            LOGGER.fine(() -> "Parsed " + filename + ": " + (parseResultForLog ? "SUCCESS" : "FAIL"));
 
             // Update counters based on results
             if (parseSucceeded) {
@@ -148,7 +163,13 @@ private TestResults runTests() throws Exception {
                 }
             }
         }
-        
+        final int yPassF = yPass;
+        final int yFailF = yFail;
+        final int nPassF = nPass;
+        final int nFailF = nFail;
+        final int iAcceptF = iAccept;
+        final int iRejectF = iReject;
+        LOGGER.fine(() -> "Finished processing files. yPass=" + yPassF + ", yFail=" + yFailF + ", nPass=" + nPassF + ", nFail=" + nFailF + ", iAccept=" + iAcceptF + ", iReject=" + iRejectF);
         return new TestResults(files.size(), skippedFiles.size(), 
             yPass, yFail, nPass, nFail, iAccept, iReject,
             shouldPassButFailed, shouldFailButPassed, skippedFiles);

json-java21-schema/pom.xml

@@ -64,6 +64,14 @@
             <version>2.15.0</version>
             <scope>test</scope>
         </dependency>
+    
+        <dependency>
+            <groupId>net.jqwik</groupId>
+            <artifactId>jqwik</artifactId>
+            <version>1.9.3</version>
+            <scope>test</scope>
+        </dependency>
+
     </dependencies>
 
     <build>

json-java21-schema/src/test/java/io/github/simbo1905/json/schema/JsonSchemaLoggingConfig.java

@@ -17,7 +17,7 @@ static void enableJulDebug() {
                 try {
                     targetLevel = Level.parse(levelProp.trim().toUpperCase(Locale.ROOT));
                 } catch (IllegalArgumentException ignored) {
-                    targetLevel = Level.INFO;
+                    System.err.println("Unrecognized logging level from 'java.util.logging.ConsoleHandler.level': " + levelProp);
                 }
             }
         }

json-java21/src/test/java/jdk/sandbox/java/util/json/ReadmeDemoTests.java

@@ -20,6 +20,9 @@ void quickStartExample() {
     JsonObject obj = (JsonObject) value;
     assertThat(((JsonString) obj.members().get("name")).value()).isEqualTo("Alice");
     assertThat(((JsonNumber) obj.members().get("age")).toNumber()).isEqualTo(30L);
+
+    String roundTrip = value.toString();
+    assertThat(roundTrip).isEqualTo(jsonString);
   }
 
   // Domain model using records
@@ -221,4 +224,4 @@ void displayFormattingExample() {
     assertThat(formatted).contains("  ]");
     assertThat(formatted).contains("}");
   }
-}
+}

pom.xml

@@ -59,8 +59,6 @@
         <download-maven-plugin.version>1.7.1</download-maven-plugin.version>
     </properties>
 
-    
-
     <dependencyManagement>
         <dependencies>
             <dependency>