Editing path as str for a revision instance causes error on push

[zatkins2]

When creating a product for the first time, it seems like a standard way of doing that is to specify a source like:

prod = client.new_product(..., sources={'map': {'path': path_as_str, 'description': 'the simulated map'}})

and then the source information is somehow further processed so that path_as_str is promoted to an actual pathlib.Path instance.

But I tried making a revision and revising the path like so:

rev = remote.creat_revision(...)

rev[my_slug] = my_slug_name
rev[my_slug].path = path_as_str

and somehow this bypasses where path_as_str becomes a pathlib.Path instance. This creates an error here because a str does not have an exists method.

The workaround of course was too do:

rev[my_slug] = Path(path_as_str)

instead, but I think it would more user-friendly if the same stuff under-the-hood that converted this from a str to a Path happened automatically.

Actually, perhaps an even nicer thing would be a way to edit/set the sources of the revision by passing a dictionary just like to new_product?

[JBorrow]

I think that's a bug, there should be an explicit conversion to Path in this function here:

hippo/henry/product.py

Line 558 in b0f24d6

if isinstance(value, LocalSource):

[JBorrow]

I'm not sure why those strings aren't getting upserted to Paths... Are they perhaps some other werid type of string like a numpy string?

[JBorrow]

As for your question about adding a possibility of using a dictionary, we'd want to implement the update function on the RevisionProduct container. That would keep it consistent with the internal dictionary type.

[zatkins2]

No it was just a python string