|
| 1 | +/** |
| 2 | + * @vitest-environment node |
| 3 | + */ |
| 4 | +import { authMockFns, permissionsMock, permissionsMockFns } from '@sim/testing' |
| 5 | +import { NextRequest } from 'next/server' |
| 6 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 7 | + |
| 8 | +const { |
| 9 | + mockIsUsingCloudStorage, |
| 10 | + mockGetStorageProvider, |
| 11 | + mockGetStorageConfig, |
| 12 | + mockCompleteS3MultipartUpload, |
| 13 | + mockCompleteBlobMultipartUpload, |
| 14 | + mockDeriveBlobBlockId, |
| 15 | + mockVerifyUploadToken, |
| 16 | + mockSignUploadToken, |
| 17 | +} = vi.hoisted(() => ({ |
| 18 | + mockIsUsingCloudStorage: vi.fn(), |
| 19 | + mockGetStorageProvider: vi.fn(), |
| 20 | + mockGetStorageConfig: vi.fn(), |
| 21 | + mockCompleteS3MultipartUpload: vi.fn(), |
| 22 | + mockCompleteBlobMultipartUpload: vi.fn(), |
| 23 | + mockDeriveBlobBlockId: vi.fn(), |
| 24 | + mockVerifyUploadToken: vi.fn(), |
| 25 | + mockSignUploadToken: vi.fn(), |
| 26 | +})) |
| 27 | + |
| 28 | +vi.mock('@/lib/uploads', () => ({ |
| 29 | + isUsingCloudStorage: mockIsUsingCloudStorage, |
| 30 | + getStorageProvider: mockGetStorageProvider, |
| 31 | + getStorageConfig: mockGetStorageConfig, |
| 32 | +})) |
| 33 | + |
| 34 | +vi.mock('@/lib/uploads/core/upload-token', () => ({ |
| 35 | + signUploadToken: mockSignUploadToken, |
| 36 | + verifyUploadToken: mockVerifyUploadToken, |
| 37 | +})) |
| 38 | + |
| 39 | +vi.mock('@/lib/uploads/providers/s3/client', () => ({ |
| 40 | + completeS3MultipartUpload: mockCompleteS3MultipartUpload, |
| 41 | + initiateS3MultipartUpload: vi.fn(), |
| 42 | + getS3MultipartPartUrls: vi.fn(), |
| 43 | + abortS3MultipartUpload: vi.fn(), |
| 44 | +})) |
| 45 | + |
| 46 | +vi.mock('@/lib/uploads/providers/blob/client', () => ({ |
| 47 | + completeMultipartUpload: mockCompleteBlobMultipartUpload, |
| 48 | + deriveBlobBlockId: mockDeriveBlobBlockId, |
| 49 | + initiateMultipartUpload: vi.fn(), |
| 50 | + getMultipartPartUrls: vi.fn(), |
| 51 | + abortMultipartUpload: vi.fn(), |
| 52 | +})) |
| 53 | + |
| 54 | +vi.mock('@/lib/workspaces/permissions/utils', () => permissionsMock) |
| 55 | + |
| 56 | +import { POST } from '@/app/api/files/multipart/route' |
| 57 | + |
| 58 | +const tokenPayload = { |
| 59 | + uploadId: 'upload-1', |
| 60 | + key: 'workspace/ws-1/123-abc-file.bin', |
| 61 | + userId: 'user-1', |
| 62 | + workspaceId: 'ws-1', |
| 63 | + context: 'workspace' as const, |
| 64 | +} |
| 65 | + |
| 66 | +const makeRequest = (action: string, body: unknown) => |
| 67 | + new NextRequest(`http://localhost/api/files/multipart?action=${action}`, { |
| 68 | + method: 'POST', |
| 69 | + headers: { 'Content-Type': 'application/json' }, |
| 70 | + body: JSON.stringify(body), |
| 71 | + }) |
| 72 | + |
| 73 | +describe('POST /api/files/multipart action=complete', () => { |
| 74 | + beforeEach(() => { |
| 75 | + vi.clearAllMocks() |
| 76 | + authMockFns.mockGetSession.mockResolvedValue({ user: { id: 'user-1' } }) |
| 77 | + permissionsMockFns.mockGetUserEntityPermissions.mockResolvedValue('write') |
| 78 | + mockIsUsingCloudStorage.mockReturnValue(true) |
| 79 | + mockGetStorageConfig.mockReturnValue({ bucket: 'b', region: 'r' }) |
| 80 | + mockVerifyUploadToken.mockReturnValue({ valid: true, payload: tokenPayload }) |
| 81 | + mockSignUploadToken.mockReturnValue('signed-token') |
| 82 | + mockCompleteS3MultipartUpload.mockResolvedValue({ |
| 83 | + location: 'loc', |
| 84 | + path: '/api/files/serve/...', |
| 85 | + key: tokenPayload.key, |
| 86 | + }) |
| 87 | + mockCompleteBlobMultipartUpload.mockResolvedValue({ |
| 88 | + location: 'loc', |
| 89 | + path: '/api/files/serve/...', |
| 90 | + key: tokenPayload.key, |
| 91 | + }) |
| 92 | + mockDeriveBlobBlockId.mockImplementation( |
| 93 | + (n: number) => `block-${n.toString().padStart(6, '0')}` |
| 94 | + ) |
| 95 | + }) |
| 96 | + |
| 97 | + it('rejects parts without partNumber', async () => { |
| 98 | + mockGetStorageProvider.mockReturnValue('s3') |
| 99 | + const res = await POST( |
| 100 | + makeRequest('complete', { |
| 101 | + uploadToken: 'tok', |
| 102 | + parts: [{ etag: 'abc' }], |
| 103 | + }) |
| 104 | + ) |
| 105 | + expect(res.status).toBe(400) |
| 106 | + expect(mockCompleteS3MultipartUpload).not.toHaveBeenCalled() |
| 107 | + }) |
| 108 | + |
| 109 | + it('S3 path requires etag and forwards { ETag, PartNumber }', async () => { |
| 110 | + mockGetStorageProvider.mockReturnValue('s3') |
| 111 | + |
| 112 | + const missingEtag = await POST( |
| 113 | + makeRequest('complete', { |
| 114 | + uploadToken: 'tok', |
| 115 | + parts: [{ partNumber: 1 }], |
| 116 | + }) |
| 117 | + ) |
| 118 | + expect(missingEtag.status).toBe(500) |
| 119 | + |
| 120 | + mockCompleteS3MultipartUpload.mockClear() |
| 121 | + |
| 122 | + const ok = await POST( |
| 123 | + makeRequest('complete', { |
| 124 | + uploadToken: 'tok', |
| 125 | + parts: [ |
| 126 | + { partNumber: 1, etag: 'aaa' }, |
| 127 | + { partNumber: 2, etag: 'bbb' }, |
| 128 | + ], |
| 129 | + }) |
| 130 | + ) |
| 131 | + expect(ok.status).toBe(200) |
| 132 | + expect(mockCompleteS3MultipartUpload).toHaveBeenCalledWith( |
| 133 | + tokenPayload.key, |
| 134 | + tokenPayload.uploadId, |
| 135 | + [ |
| 136 | + { ETag: 'aaa', PartNumber: 1 }, |
| 137 | + { ETag: 'bbb', PartNumber: 2 }, |
| 138 | + ], |
| 139 | + expect.any(Object) |
| 140 | + ) |
| 141 | + }) |
| 142 | + |
| 143 | + it('Blob path derives blockId from partNumber and ignores etag', async () => { |
| 144 | + mockGetStorageProvider.mockReturnValue('blob') |
| 145 | + mockGetStorageConfig.mockReturnValue({ |
| 146 | + containerName: 'c', |
| 147 | + accountName: 'a', |
| 148 | + accountKey: 'k', |
| 149 | + }) |
| 150 | + |
| 151 | + const res = await POST( |
| 152 | + makeRequest('complete', { |
| 153 | + uploadToken: 'tok', |
| 154 | + parts: [{ partNumber: 1, etag: 'irrelevant' }, { partNumber: 2 }], |
| 155 | + }) |
| 156 | + ) |
| 157 | + |
| 158 | + expect(res.status).toBe(200) |
| 159 | + expect(mockDeriveBlobBlockId).toHaveBeenCalledWith(1) |
| 160 | + expect(mockDeriveBlobBlockId).toHaveBeenCalledWith(2) |
| 161 | + expect(mockCompleteBlobMultipartUpload).toHaveBeenCalledWith( |
| 162 | + tokenPayload.key, |
| 163 | + [ |
| 164 | + { partNumber: 1, blockId: 'block-000001' }, |
| 165 | + { partNumber: 2, blockId: 'block-000002' }, |
| 166 | + ], |
| 167 | + expect.objectContaining({ containerName: 'c' }) |
| 168 | + ) |
| 169 | + }) |
| 170 | + |
| 171 | + it('returns 403 when token is invalid', async () => { |
| 172 | + mockGetStorageProvider.mockReturnValue('s3') |
| 173 | + mockVerifyUploadToken.mockReturnValueOnce({ valid: false }) |
| 174 | + const res = await POST( |
| 175 | + makeRequest('complete', { |
| 176 | + uploadToken: 'bad', |
| 177 | + parts: [{ partNumber: 1, etag: 'a' }], |
| 178 | + }) |
| 179 | + ) |
| 180 | + expect(res.status).toBe(403) |
| 181 | + }) |
| 182 | + |
| 183 | + it('batch complete normalizes per upload', async () => { |
| 184 | + mockGetStorageProvider.mockReturnValue('s3') |
| 185 | + const res = await POST( |
| 186 | + makeRequest('complete', { |
| 187 | + uploads: [ |
| 188 | + { |
| 189 | + uploadToken: 'tok-a', |
| 190 | + parts: [{ partNumber: 1, etag: 'aaa' }], |
| 191 | + }, |
| 192 | + { |
| 193 | + uploadToken: 'tok-b', |
| 194 | + parts: [{ partNumber: 1, etag: 'bbb' }], |
| 195 | + }, |
| 196 | + ], |
| 197 | + }) |
| 198 | + ) |
| 199 | + expect(res.status).toBe(200) |
| 200 | + expect(mockCompleteS3MultipartUpload).toHaveBeenCalledTimes(2) |
| 201 | + }) |
| 202 | +}) |
0 commit comments