fix notif error + sync manifest undefined exit

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.ts

@@ -302,6 +302,8 @@ export function createBlockEventHandlers(
     updateConsole(
       data.blockId,
       {
+        blockName: data.blockName,
+        blockType: data.blockType,
         executionOrder: data.executionOrder,
         input: data.input || {},
         replaceOutput: data.output,
@@ -320,6 +322,8 @@ export function createBlockEventHandlers(
     updateConsole(
       data.blockId,
       {
+        blockName: data.blockName,
+        blockType: data.blockType,
         executionOrder: data.executionOrder,
         input: data.input || {},
         replaceOutput: {},
@@ -493,6 +497,8 @@ export function reconcileFinalBlockLogs(
         log.blockId,
         {
           executionOrder: log.executionOrder,
+          blockName: log.blockName,
+          blockType: log.blockType,
           replaceOutput: (log.output ?? {}) as Record<string, unknown>,
           ...(log.input ? { input: log.input } : {}),
           success: log.success,
@@ -576,6 +582,8 @@ function spanConsoleIdentity(span: TraceSpan, childWorkflowInstanceId: string):
   const iterationContainerId = span.loopId ?? span.parallelId
   const iterationType = span.loopId ? 'loop' : span.parallelId ? 'parallel' : undefined
   return {
+    blockName: span.name,
+    blockType: span.type,
     ...(span.executionOrder !== undefined && { executionOrder: span.executionOrder }),
     ...(span.iterationIndex !== undefined && { iterationCurrent: span.iterationIndex }),
     ...(iterationType !== undefined && { iterationType }),

apps/sim/executor/variables/resolvers/reference.test.ts

@@ -176,6 +176,38 @@ describe('navigatePath', () => {
     })
   })
 
+  describe('large array manifests', () => {
+    it('returns undefined for sync index access when the chunk is not cached', () => {
+      const manifest = {
+        __simLargeArrayManifest: true,
+        version: 2,
+        kind: 'array',
+        totalCount: 1,
+        chunkCount: 1,
+        byteSize: 16,
+        chunks: [
+          {
+            ref: {
+              __simLargeValueRef: true,
+              version: 1,
+              id: 'lv_ABCDEFGHIJKL',
+              kind: 'array',
+              size: 16,
+              executionId: 'execution-1',
+            },
+            count: 1,
+            byteSize: 16,
+          },
+        ],
+        preview: [{ id: 1 }],
+      }
+
+      expect(navigatePath(manifest, ['0'])).toBeUndefined()
+      expect(navigatePath(manifest, ['length'])).toBe(1)
+      expect(navigatePath(manifest, ['preview'])).toEqual([{ id: 1 }])
+    })
+  })
+
   describe('bracket notation edge cases', () => {
     it.concurrent('should handle bracket notation with property access', () => {
       const obj = { data: [{ value: 100 }, { value: 200 }] }

apps/sim/executor/variables/resolvers/reference.ts

@@ -1,4 +1,7 @@
-import { materializeLargeValueRefSyncOrThrow } from '@/lib/execution/payloads/cache'
+import {
+  materializeLargeValueRefSync,
+  materializeLargeValueRefSyncOrThrow,
+} from '@/lib/execution/payloads/cache'
 import {
   isLargeArrayManifest,
   type LargeArrayManifest,
@@ -79,7 +82,10 @@ function readManifestIndexSync(
   for (const chunk of manifest.chunks) {
     const nextOffset = offset + chunk.count
     if (index < nextOffset) {
-      const materialized = materializeLargeValueRefSyncOrThrow(chunk.ref, executionContext)
+      const materialized = materializeLargeValueRefSync(chunk.ref, executionContext)
+      if (materialized === undefined) {
+        return undefined
+      }
       if (!Array.isArray(materialized)) {
         throw new Error('Large array manifest chunk must materialize to an array.')
       }

apps/sim/stores/terminal/console/store.test.ts

@@ -5,7 +5,9 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.unmock('@/stores/terminal')
 vi.unmock('@/stores/terminal/console/store')
+vi.unmock('@/stores/notifications')
 
+import { useNotificationStore } from '@/stores/notifications'
 import { useTerminalConsoleStore } from '@/stores/terminal/console/store'
 
 describe('terminal console store', () => {
@@ -17,6 +19,9 @@ describe('terminal console store', () => {
       isOpen: false,
       _hasHydrated: true,
     })
+    useNotificationStore.setState({
+      notifications: [],
+    })
   })
 
   it('normalizes oversized payloads when adding console entries', () => {
@@ -117,6 +122,37 @@ describe('terminal console store', () => {
     expect(after.getWorkflowEntries('wf-1')[0].output).toMatchObject({ status: 'updated' })
   })
 
+  it('uses the block name from error updates in notifications', () => {
+    useTerminalConsoleStore.getState().addConsole({
+      workflowId: 'wf-1',
+      blockId: 'block-1',
+      blockName: 'Unknown Block',
+      blockType: 'function',
+      executionId: 'exec-1',
+      executionOrder: 1,
+      isRunning: true,
+    })
+
+    useTerminalConsoleStore.getState().updateConsole(
+      'block-1',
+      {
+        blockName: 'Transform Data',
+        blockType: 'function',
+        executionOrder: 1,
+        error: 'Boom',
+        success: false,
+      },
+      'exec-1'
+    )
+
+    const [entry] = useTerminalConsoleStore.getState().getWorkflowEntries('wf-1')
+    const [notification] = useNotificationStore.getState().notifications
+
+    expect(entry.blockName).toBe('Transform Data')
+    expect(notification.message).toBe('Transform Data: Boom')
+    expect(notification.action?.message).toContain('Error in Transform Data.')
+  })
+
   describe('cancelRunningEntries', () => {
     it('flips a plain running entry to canceled', () => {
       useTerminalConsoleStore.getState().addConsole({

apps/sim/stores/terminal/console/store.ts

@@ -507,6 +507,14 @@ export const useTerminalConsoleStore = create<ConsoleStore>()(
                 : normalizeConsoleOutput(mergedOutput)
           }
 
+          if (update.blockName !== undefined) {
+            updatedEntry.blockName = update.blockName
+          }
+
+          if (update.blockType !== undefined) {
+            updatedEntry.blockType = update.blockType
+          }
+
           if (update.error !== undefined) {
             updatedEntry.error = normalizeConsoleError(update.error)
           }
@@ -605,7 +613,7 @@ export const useTerminalConsoleStore = create<ConsoleStore>()(
           .find((entry) => matchesEntryForUpdate(entry, blockId, executionId, update))
         notifyBlockError({
           error: update.error,
-          blockName: matchingEntry?.blockName || 'Unknown Block',
+          blockName: update.blockName || matchingEntry?.blockName || 'Unknown Block',
           workflowId: matchingEntry?.workflowId,
           logContext: { blockId },
         })

apps/sim/stores/terminal/console/types.ts

@@ -38,6 +38,8 @@ export interface ConsoleUpdate {
   content?: string
   output?: Partial<NormalizedBlockOutput>
   replaceOutput?: NormalizedBlockOutput
+  blockName?: string
+  blockType?: string
   executionOrder?: number
   error?: string | Error | null
   warning?: string