simstudioai
diff --git a/‎apps/sim/app/api/cron/cleanup-stale-executions/route.ts‎
Lines changed: 35 additions & 1 deletion b/‎apps/sim/app/api/cron/cleanup-stale-executions/route.ts‎
Lines changed: 35 additions & 1 deletion
diff --git a/‎apps/sim/app/api/table/[tableId]/import-async/route.test.ts‎
Lines changed: 144 additions & 0 deletions b/‎apps/sim/app/api/table/[tableId]/import-async/route.test.ts‎
Lines changed: 144 additions & 0 deletions
diff --git a/‎apps/sim/app/api/table/[tableId]/import-async/route.ts‎
Lines changed: 92 additions & 0 deletions b/‎apps/sim/app/api/table/[tableId]/import-async/route.ts‎
Lines changed: 92 additions & 0 deletions
@@ -1,5 +1,5 @@
 import { asyncJobs, db } from '@sim/db'
-import { workflowExecutionLogs } from '@sim/db/schema'
+import { userTableDefinitions, workflowExecutionLogs } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { toError } from '@sim/utils/errors'
 import { and, eq, inArray, lt, sql } from 'drizzle-orm'
@@ -110,6 +110,37 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
       })
     }
 
+    // Mark stale table imports as failed. Imports run detached on the web container and
+    // are lost if the pod is killed mid-load. `updatedAt` is bumped by progress updates, so
+    // an `importing` table with no recent update has stalled (not merely slow). Rows are
+    // left in place (no rollback); the user re-imports.
+    let staleImportsMarkedFailed = 0
+    try {
+      const staleImports = await db
+        .update(userTableDefinitions)
+        .set({
+          importStatus: 'failed',
+          importError: `Import terminated: no progress for more than ${STALE_THRESHOLD_MINUTES} minutes (worker timeout or crash)`,
+          updatedAt: new Date(),
+        })
+        .where(
+          and(
+            eq(userTableDefinitions.importStatus, 'importing'),
+            lt(userTableDefinitions.updatedAt, staleThreshold)
+          )
+        )
+        .returning({ id: userTableDefinitions.id })
+
+      staleImportsMarkedFailed = staleImports.length
+      if (staleImportsMarkedFailed > 0) {
+        logger.info(`Marked ${staleImportsMarkedFailed} stale table imports as failed`)
+      }
+    } catch (error) {
+      logger.error('Failed to clean up stale table imports:', {
+        error: toError(error).message,
+      })
+    }
+
     // Clean up stale pending jobs (never started, e.g., due to server crash before startJob())
     let stalePendingJobsMarkedFailed = 0
 
@@ -179,6 +210,9 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
         staleThresholdMinutes: STALE_THRESHOLD_MINUTES,
         retentionHours: JOB_RETENTION_HOURS,
       },
+      tableImports: {
+        staleMarkedFailed: staleImportsMarkedFailed,
+      },
     })
   } catch (error) {
     logger.error('Error in stale execution cleanup job:', error)
 
@@ -0,0 +1,144 @@
+/**
+ * @vitest-environment node
+ */
+import { hybridAuthMockFns } from '@sim/testing'
+import { NextRequest } from 'next/server'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import type { TableDefinition } from '@/lib/table'
+
+const { mockCheckAccess, mockMarkTableImporting, mockRunTableImport } = vi.hoisted(() => ({
+  mockCheckAccess: vi.fn(),
+  mockMarkTableImporting: vi.fn(),
+  mockRunTableImport: vi.fn(),
+}))
+
+vi.mock('@sim/utils/id', () => ({
+  generateId: vi.fn().mockReturnValue('import-id-xyz'),
+  generateShortId: vi.fn().mockReturnValue('short-id'),
+}))
+vi.mock('@/lib/table/service', () => ({ markTableImporting: mockMarkTableImporting }))
+vi.mock('@/lib/table/import-runner', () => ({ runTableImport: mockRunTableImport }))
+vi.mock('@/lib/core/utils/background', () => ({
+  runDetached: (_label: string, work: () => Promise<unknown>) => {
+    void work()
+  },
+}))
+vi.mock('@/app/api/table/utils', async () => {
+  const { NextResponse } = await import('next/server')
+  return {
+    checkAccess: mockCheckAccess,
+    accessError: (result: { status: number }) =>
+      NextResponse.json({ error: 'denied' }, { status: result.status }),
+  }
+})
+
+import { POST } from '@/app/api/table/[tableId]/import-async/route'
+
+function buildTable(overrides: Partial<TableDefinition> = {}): TableDefinition {
+  return {
+    id: 'tbl_1',
+    name: 'People',
+    description: null,
+    schema: { columns: [{ name: 'name', type: 'string' }] },
+    metadata: null,
+    rowCount: 0,
+    maxRows: 1_000_000,
+    workspaceId: 'workspace-1',
+    createdBy: 'user-1',
+    archivedAt: null,
+    createdAt: new Date(),
+    updatedAt: new Date(),
+    ...overrides,
+  }
+}
+
+function makeRequest(body: unknown, tableId = 'tbl_1') {
+  const req = new NextRequest(`http://localhost:3000/api/table/${tableId}/import-async`, {
+    method: 'POST',
+    headers: { 'content-type': 'application/json' },
+    body: JSON.stringify(body),
+  })
+  return POST(req, { params: Promise.resolve({ tableId }) })
+}
+
+const validBody = {
+  workspaceId: 'workspace-1',
+  fileKey: 'workspace/workspace-1/123-data.csv',
+  fileName: 'data.csv',
+  mode: 'append',
+}
+
+describe('POST /api/table/[tableId]/import-async', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    hybridAuthMockFns.mockCheckSessionOrInternalAuth.mockResolvedValue({
+      success: true,
+      userId: 'user-1',
+      authType: 'session',
+    })
+    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable() })
+    mockMarkTableImporting.mockResolvedValue(true)
+    mockRunTableImport.mockResolvedValue(undefined)
+  })
+
+  it('marks the table importing and kicks off the worker with mode + mapping', async () => {
+    const response = await makeRequest({
+      ...validBody,
+      mode: 'replace',
+      mapping: { Name: 'name' },
+      createColumns: ['Extra'],
+    })
+    const data = await response.json()
+
+    expect(response.status).toBe(200)
+    expect(data.data).toEqual({ tableId: 'tbl_1', importId: 'import-id-xyz' })
+    expect(mockMarkTableImporting).toHaveBeenCalledWith('tbl_1', 'import-id-xyz')
+    expect(mockRunTableImport).toHaveBeenCalledWith(
+      expect.objectContaining({
+        tableId: 'tbl_1',
+        mode: 'replace',
+        delimiter: ',',
+        mapping: { Name: 'name' },
+        createColumns: ['Extra'],
+      })
+    )
+  })
+
+  it('returns 409 when the table is already importing (claim lost)', async () => {
+    mockMarkTableImporting.mockResolvedValue(false)
+    const response = await makeRequest(validBody)
+    expect(response.status).toBe(409)
+    expect(mockRunTableImport).not.toHaveBeenCalled()
+  })
+
+  it('returns 401 when unauthenticated', async () => {
+    hybridAuthMockFns.mockCheckSessionOrInternalAuth.mockResolvedValue({ success: false })
+    const response = await makeRequest(validBody)
+    expect(response.status).toBe(401)
+    expect(mockMarkTableImporting).not.toHaveBeenCalled()
+  })
+
+  it('returns the access error status when access is denied', async () => {
+    mockCheckAccess.mockResolvedValue({ ok: false, status: 403 })
+    const response = await makeRequest(validBody)
+    expect(response.status).toBe(403)
+    expect(mockRunTableImport).not.toHaveBeenCalled()
+  })
+
+  it('returns 400 when the target table is archived', async () => {
+    mockCheckAccess.mockResolvedValue({ ok: true, table: buildTable({ archivedAt: new Date() }) })
+    const response = await makeRequest(validBody)
+    expect(response.status).toBe(400)
+    expect(mockRunTableImport).not.toHaveBeenCalled()
+  })
+
+  it('returns 400 on workspace mismatch', async () => {
+    const response = await makeRequest({ ...validBody, workspaceId: 'other-ws' })
+    expect(response.status).toBe(400)
+  })
+
+  it('returns 400 for an invalid mode', async () => {
+    const response = await makeRequest({ ...validBody, mode: 'bogus' })
+    expect(response.status).toBe(400)
+  })
+})
@@ -0,0 +1,92 @@
+import { createLogger } from '@sim/logger'
+import { generateId } from '@sim/utils/id'
+import { type NextRequest, NextResponse } from 'next/server'
+import { importIntoTableAsyncContract } from '@/lib/api/contracts/tables'
+import { parseRequest } from '@/lib/api/server'
+import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
+import { runDetached } from '@/lib/core/utils/background'
+import { generateRequestId } from '@/lib/core/utils/request'
+import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { runTableImport } from '@/lib/table/import-runner'
+import { markTableImporting } from '@/lib/table/service'
+import { accessError, checkAccess } from '@/app/api/table/utils'
+
+const logger = createLogger('TableImportIntoAsync')
+
+export const runtime = 'nodejs'
+export const dynamic = 'force-dynamic'
+
+interface RouteParams {
+  params: Promise<{ tableId: string }>
+}
+
+export const POST = withRouteHandler(async (request: NextRequest, { params }: RouteParams) => {
+  const requestId = generateRequestId()
+
+  const authResult = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
+  if (!authResult.success || !authResult.userId) {
+    return NextResponse.json({ error: 'Authentication required' }, { status: 401 })
+  }
+  const userId = authResult.userId
+
+  const parsed = await parseRequest(importIntoTableAsyncContract, request, { params })
+  if (!parsed.success) return parsed.response
+  const { tableId } = parsed.data.params
+  const { workspaceId, fileKey, fileName, mode, mapping, createColumns } = parsed.data.body
+
+  const access = await checkAccess(tableId, userId, 'write')
+  if (!access.ok) return accessError(access, requestId, tableId)
+  const { table } = access
+
+  if (table.workspaceId !== workspaceId) {
+    return NextResponse.json({ error: 'Invalid workspace ID' }, { status: 400 })
+  }
+  // The fileKey is client-supplied — ensure it points at this workspace's storage prefix so a
+  // caller can't import another workspace's uploaded object.
+  if (!fileKey.startsWith(`workspace/${workspaceId}/`)) {
+    return NextResponse.json({ error: 'Invalid file key for workspace' }, { status: 400 })
+  }
+  if (table.archivedAt) {
+    return NextResponse.json({ error: 'Cannot import into an archived table' }, { status: 400 })
+  }
+
+  const ext = fileName.split('.').pop()?.toLowerCase()
+  if (ext !== 'csv' && ext !== 'tsv') {
+    return NextResponse.json({ error: 'Only CSV and TSV files are supported' }, { status: 400 })
+  }
+  const delimiter = ext === 'tsv' ? '\t' : ','
+
+  // Atomically claim the table — the single concurrency gate. If another import already holds it,
+  // this returns false (no overlapping workers writing colliding row positions).
+  const importId = generateId()
+  const claimed = await markTableImporting(tableId, importId)
+  if (!claimed) {
+    return NextResponse.json(
+      { error: 'An import is already in progress for this table' },
+      { status: 409 }
+    )
+  }
+
+  runDetached('table-import', () =>
+    runTableImport({
+      importId,
+      tableId,
+      workspaceId,
+      userId,
+      fileKey,
+      fileName,
+      delimiter,
+      mode,
+      mapping,
+      createColumns,
+    })
+  )
+
+  logger.info(`[${requestId}] Async CSV import into existing table started`, {
+    tableId,
+    importId,
+    mode,
+    fileName,
+  })
+  return NextResponse.json({ success: true, data: { tableId, importId } })
+})