fix(tables): log rollback failures and surface a clear reason on failed CSV import

Author: TheodoreSpeaks

apps/sim/lib/copilot/tools/server/table/user-table.test.ts

@@ -249,6 +249,7 @@ describe('userTableServerTool.create_from_file', () => {
     mockDownloadWorkspaceFile.mockResolvedValue(Buffer.from('name,age\nAlice,30\nBob,40'))
     mockGetWorkspaceTableLimits.mockResolvedValue({ maxRowsPerTable: 1000, maxTables: 3 })
     mockCreateTable.mockResolvedValue(buildTable({ id: 'tbl_new', name: 'people' }))
+    mockDeleteTable.mockResolvedValue(undefined)
     mockBatchInsertRows.mockImplementation(async (data: { rows: unknown[] }) =>
       data.rows.map((_, i) => ({ id: `row_${i}` }))
     )
@@ -286,8 +287,8 @@ describe('userTableServerTool.create_from_file', () => {
     expect(mockDeleteTable).not.toHaveBeenCalled()
   })
 
-  it('deletes the created table when row insertion fails', async () => {
-    mockBatchInsertRows.mockRejectedValueOnce(new Error('Maximum row limit (1000) reached'))
+  it('rolls back the created table and reports the reason when row insertion fails', async () => {
+    mockBatchInsertRows.mockRejectedValueOnce(new Error('Row 2: Column "email" must be unique'))
 
     const result = await userTableServerTool.execute(
       { operation: 'create_from_file', args: { fileId: 'file-1' } },
@@ -296,6 +297,8 @@ describe('userTableServerTool.create_from_file', () => {
 
     expect(result.success).toBe(false)
     expect(mockDeleteTable).toHaveBeenCalledWith('tbl_new', expect.any(String))
+    expect(result.message).toMatch(/rolled back/i)
+    expect(result.message).toMatch(/must be unique/i)
   })
 })
 

apps/sim/lib/copilot/tools/server/table/user-table.ts

@@ -788,8 +788,28 @@ export const userTableServerTool: BaseServerTool<UserTableArgs, UserTableResult>
           try {
             inserted = await batchInsertAll(table.id, coerced, table, workspaceId, context)
           } catch (insertError) {
-            await deleteTable(table.id, requestId).catch(() => {})
-            throw insertError
+            const cleanupRequestId = generateId().slice(0, 8)
+            await deleteTable(table.id, cleanupRequestId).catch((cleanupError) => {
+              logger.error('Failed to roll back table after import failure', {
+                tableId: table.id,
+                error: toError(cleanupError).message,
+              })
+            })
+            const reason = toError(insertError).message
+            const cause =
+              insertError instanceof Error && insertError.cause
+                ? toError(insertError.cause).message
+                : undefined
+            logger.error('Failed to import rows into new table', {
+              tableId: table.id,
+              fileName: file.name,
+              error: reason,
+              cause,
+            })
+            return {
+              success: false,
+              message: `Failed to import rows from "${file.name}" — the table was rolled back. ${cause ? `${reason} (${cause})` : reason}`,
+            }
           }
 
           logger.info('Table created from file', {