Update skills

Author: Sg312

apps/sim/app/api/skills/route.ts

@@ -11,6 +11,7 @@ import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 import { captureServerEvent } from '@/lib/posthog/server'
+import { isBuiltinSkillId } from '@/lib/workflows/skills/builtin-skills'
 import { deleteSkill, listSkills, upsertSkills } from '@/lib/workflows/skills/operations'
 import { getUserEntityPermissions } from '@/lib/workspaces/permissions/utils'
 
@@ -47,8 +48,9 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
     }
 
     const result = await listSkills({ workspaceId })
+    const data = result.map((s) => ({ ...s, readOnly: isBuiltinSkillId(s.id) }))
 
-    return NextResponse.json({ data: result }, { status: 200 })
+    return NextResponse.json({ data }, { status: 200 })
   } catch (error) {
     logger.error(`[${requestId}] Error fetching skills:`, error)
     return NextResponse.json({ error: 'Failed to fetch skills' }, { status: 500 })

apps/sim/app/workspace/[workspaceId]/skills/components/skill-modal/skill-modal.tsx

@@ -144,6 +144,7 @@ export function SkillModal({
   )
 
   const isEditing = !!initialValues
+  const readOnly = !!initialValues?.readOnly
   const showFooter = activeTab === 'create' || isEditing
 
   return (
@@ -249,15 +250,25 @@ export function SkillModal({
       {showFooter && (
         <ChipModalFooter className={isEditing && onDelete ? 'justify-between' : undefined}>
           {isEditing && onDelete && (
-            <Chip variant='destructive' flush onClick={() => onDelete(initialValues.id)}>
+            <Chip
+              variant='destructive'
+              flush
+              onClick={() => onDelete(initialValues.id)}
+              disabled={readOnly}
+            >
               Delete
             </Chip>
           )}
           <div className='flex gap-2'>
             <Chip variant='filled' flush onClick={() => onOpenChange(false)}>
               Cancel
             </Chip>
-            <Chip variant='primary' flush onClick={handleSave} disabled={saving || !hasChanges}>
+            <Chip
+              variant='primary'
+              flush
+              onClick={handleSave}
+              disabled={readOnly || saving || !hasChanges}
+            >
               {saving ? 'Saving...' : isEditing ? 'Update' : 'Create'}
             </Chip>
           </div>

apps/sim/app/workspace/[workspaceId]/skills/fixtures/sample-skills.ts

@@ -1,6 +1,6 @@
 'use client'
 
-import { useMemo, useState } from 'react'
+import { useState } from 'react'
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
 import { ArrowRight, Plus, Search } from 'lucide-react'
@@ -10,10 +10,6 @@ import { AgentSkillsIcon } from '@/components/icons'
 import { IntegrationTabsHeader } from '@/app/workspace/[workspaceId]/integrations/components/integration-tabs-header'
 import { ShowcaseWithExplore } from '@/app/workspace/[workspaceId]/integrations/components/showcase-with-explore'
 import { SkillModal } from '@/app/workspace/[workspaceId]/skills/components/skill-modal'
-import {
-  getSampleSkills,
-  PREVIEW_SKILLS_WITH_SAMPLES,
-} from '@/app/workspace/[workspaceId]/skills/fixtures/sample-skills'
 import type { SkillDefinition } from '@/hooks/queries/skills'
 import { useDeleteSkill, useSkills } from '@/hooks/queries/skills'
 
@@ -86,12 +82,7 @@ export function Skills() {
   const [skillToDelete, setSkillToDelete] = useState<{ id: string; name: string } | null>(null)
   const [showDeleteDialog, setShowDeleteDialog] = useState(false)
 
-  const allSkills = useMemo(() => {
-    if (!PREVIEW_SKILLS_WITH_SAMPLES) return skills
-    return [...getSampleSkills(workspaceId), ...skills]
-  }, [skills, workspaceId])
-
-  const filteredSkills = allSkills.filter((s) => {
+  const filteredSkills = skills.filter((s) => {
     if (!searchTerm.trim()) return true
     const searchLower = searchTerm.toLowerCase()
     return (
@@ -101,7 +92,7 @@ export function Skills() {
   })
 
   const handleDeleteClick = (skillId: string) => {
-    const s = allSkills.find((sk) => sk.id === skillId)
+    const s = skills.find((sk) => sk.id === skillId)
     if (!s) return
 
     setSkillToDelete({ id: skillId, name: s.name })

apps/sim/app/workspace/[workspaceId]/skills/skills.tsx

@@ -3,6 +3,10 @@ import { skill } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { and, eq, inArray } from 'drizzle-orm'
 import type { SkillInput } from '@/executor/handlers/agent/types'
+import {
+  getBuiltinSkillById,
+  getBuiltinSkillByName,
+} from '@/lib/workflows/skills/builtin-skills'
 
 const logger = createLogger('SkillsResolver')
 
@@ -29,18 +33,29 @@ export async function resolveSkillMetadata(
 ): Promise<SkillMetadata[]> {
   if (!skillInputs.length || !workspaceId) return []
 
-  const skillIds = skillInputs.map((s) => s.skillId)
+  const metadata: SkillMetadata[] = []
+  const dbSkillIds: string[] = []
+  for (const input of skillInputs) {
+    const builtin = getBuiltinSkillById(input.skillId)
+    if (builtin) {
+      metadata.push({ name: builtin.name, description: builtin.description })
+    } else {
+      dbSkillIds.push(input.skillId)
+    }
+  }
+
+  if (dbSkillIds.length === 0) return metadata
 
   try {
     const rows = await db
       .select({ name: skill.name, description: skill.description })
       .from(skill)
-      .where(and(eq(skill.workspaceId, workspaceId), inArray(skill.id, skillIds)))
+      .where(and(eq(skill.workspaceId, workspaceId), inArray(skill.id, dbSkillIds)))
 
-    return rows
+    return [...metadata, ...rows]
   } catch (error) {
-    logger.error('Failed to resolve skill metadata', { error, skillIds, workspaceId })
-    return []
+    logger.error('Failed to resolve skill metadata', { error, dbSkillIds, workspaceId })
+    return metadata
   }
 }
 
@@ -54,6 +69,9 @@ export async function resolveSkillContent(
 ): Promise<string | null> {
   if (!skillName || !workspaceId) return null
 
+  const builtin = getBuiltinSkillByName(skillName)
+  if (builtin) return builtin.content
+
   try {
     const rows = await db
       .select({ content: skill.content, name: skill.name })
@@ -79,6 +97,9 @@ export async function resolveSkillContentById(
 ): Promise<{ name: string; content: string } | null> {
   if (!skillId || !workspaceId) return null
 
+  const builtin = getBuiltinSkillById(skillId)
+  if (builtin) return { name: builtin.name, content: builtin.content }
+
   try {
     const rows = await db
       .select({ content: skill.content, name: skill.name })

apps/sim/executor/handlers/agent/skills-resolver.ts

@@ -10,6 +10,8 @@ export const skillSchema = z.object({
   content: z.string(),
   createdAt: z.string(),
   updatedAt: z.string(),
+  /** True for built-in template skills, which are read-only and not stored in the DB. */
+  readOnly: z.boolean().optional(),
 })
 
 export type Skill = z.output<typeof skillSchema>

apps/sim/lib/api/contracts/skills.ts

@@ -0,0 +1,34 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import {
+  BUILTIN_SKILLS,
+  getBuiltinSkillById,
+  getBuiltinSkillByName,
+  isBuiltinSkillId,
+} from './builtin-skills'
+
+describe('builtin skills', () => {
+  it('ships the four template skills with stable ids and valid fields', () => {
+    expect(BUILTIN_SKILLS.map((s) => s.id)).toEqual([
+      'builtin-connect-integration',
+      'builtin-research',
+      'builtin-create-table',
+      'builtin-deploy-workflow',
+    ])
+    for (const s of BUILTIN_SKILLS) {
+      expect(s.name).toMatch(/^[a-z0-9]+(-[a-z0-9]+)*$/)
+      expect(s.description.length).toBeGreaterThan(0)
+      expect(s.content.length).toBeGreaterThan(0)
+    }
+  })
+
+  it('resolves by id and name (case-insensitive) and reports membership', () => {
+    expect(getBuiltinSkillById('builtin-research')?.name).toBe('research')
+    expect(getBuiltinSkillByName('RESEARCH')?.id).toBe('builtin-research')
+    expect(isBuiltinSkillId('builtin-deploy-workflow')).toBe(true)
+    expect(isBuiltinSkillId('sk-some-db-id')).toBe(false)
+    expect(getBuiltinSkillById('does-not-exist')).toBeUndefined()
+  })
+})