address comments

Author: icecrasher321

apps/sim/app/api/logs/export/route.ts

@@ -115,16 +115,26 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
             for (let j = 0; j < rows.length; j++) {
               const r = rows[j] as any
               const ed = materialized[j] as Record<string, any>
+              // A single malformed/unserializable row must not abort the whole CSV
+              // stream — derive the message/trace columns defensively and fall back
+              // to empty on error so the row's metadata still exports.
               let message = ''
-              let traces: any = null
-              if (ed) {
-                if (ed.finalOutput)
-                  message =
-                    typeof ed.finalOutput === 'string'
-                      ? ed.finalOutput
-                      : JSON.stringify(ed.finalOutput)
-                if (ed.message) message = ed.message
-                if (ed.traceSpans) traces = ed.traceSpans
+              let tracesJson = ''
+              try {
+                if (ed) {
+                  if (ed.finalOutput)
+                    message =
+                      typeof ed.finalOutput === 'string'
+                        ? ed.finalOutput
+                        : JSON.stringify(ed.finalOutput)
+                  if (ed.message) message = ed.message
+                  if (ed.traceSpans) tracesJson = JSON.stringify(ed.traceSpans)
+                }
+              } catch (rowError) {
+                logger.warn('Skipping unserializable execution data for export row', {
+                  executionId: r.executionId,
+                  error: rowError instanceof Error ? rowError.message : String(rowError),
+                })
               }
               const line = [
                 escapeCsv(r.startedAt?.toISOString?.() || r.startedAt),
@@ -136,7 +146,7 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
                 escapeCsv(r.workflowId ?? ''),
                 escapeCsv(r.executionId ?? ''),
                 escapeCsv(message),
-                escapeCsv(traces ? JSON.stringify(traces) : ''),
+                escapeCsv(tracesJson),
               ].join(',')
               controller.enqueue(encoder.encode(`${line}\n`))
             }

apps/sim/app/api/v1/logs/route.ts

@@ -152,7 +152,7 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
     const needsMaterialize =
       params.details === 'full' && (params.includeFinalOutput || params.includeTraceSpans)
 
-    const formattedLogs = await mapWithConcurrency(data, MATERIALIZE_CONCURRENCY, async (log) => {
+    const buildBase = (log: (typeof data)[number]) => {
       const result: any = {
         id: log.id,
         workflowId: log.workflowId,
@@ -174,27 +174,36 @@ export const GET = withRouteHandler(async (request: NextRequest) => {
           description: log.workflowDescription,
           deleted: !log.workflowName,
         }
-
-        if (needsMaterialize && log.executionData) {
-          const execData = (await materializeExecutionData(
-            log.executionData as Record<string, unknown> | null,
-            {
-              workspaceId: log.workspaceId,
-              workflowId: log.workflowId,
-              executionId: log.executionId,
-            }
-          )) as any
-          if (params.includeFinalOutput && execData.finalOutput) {
-            result.finalOutput = execData.finalOutput
-          }
-          if (params.includeTraceSpans && execData.traceSpans) {
-            result.traceSpans = execData.traceSpans
-          }
-        }
       }
 
       return result
-    })
+    }
+
+    // Only run the bounded-concurrency materialization when the response actually
+    // needs object-storage reads; otherwise a plain synchronous map avoids the
+    // per-row worker/promise overhead.
+    const formattedLogs = needsMaterialize
+      ? await mapWithConcurrency(data, MATERIALIZE_CONCURRENCY, async (log) => {
+          const result = buildBase(log)
+          if (log.executionData) {
+            const execData = (await materializeExecutionData(
+              log.executionData as Record<string, unknown> | null,
+              {
+                workspaceId: log.workspaceId,
+                workflowId: log.workflowId,
+                executionId: log.executionId,
+              }
+            )) as any
+            if (params.includeFinalOutput && execData.finalOutput) {
+              result.finalOutput = execData.finalOutput
+            }
+            if (params.includeTraceSpans && execData.traceSpans) {
+              result.traceSpans = execData.traceSpans
+            }
+          }
+          return result
+        })
+      : data.map(buildBase)
 
     const limits = await getUserLimits(userId)