fix(dagster): guard NaN numeric coercions and bound list_assets pagination

Address PR review:
- Route all block numeric coercions (list_runs limit/createdAfter/createdBefore,
  get_run_logs logsLimit, list_assets assetsLimit) through a toFiniteNumber()
  guard so invalid/wand-generated text becomes undefined instead of NaN.
- list_assets now applies a default page size (100) when no limit is given, so
  paging stays bounded and hasMore is meaningful even when limit is omitted.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/blocks/blocks/dagster.ts

@@ -3,6 +3,13 @@ import type { BlockConfig } from '@/blocks/types'
 import { IntegrationType } from '@/blocks/types'
 import type { DagsterResponse } from '@/tools/dagster/types'
 
+/** Coerces a subBlock value to a finite number, returning undefined for empty or non-numeric input. */
+function toFiniteNumber(value: unknown): number | undefined {
+  if (value == null || value === '') return undefined
+  const parsed = Number(value)
+  return Number.isFinite(parsed) ? parsed : undefined
+}
+
 export const DagsterBlock: BlockConfig<DagsterResponse> = {
   type: 'dagster',
   name: 'Dagster',
@@ -475,19 +482,16 @@ Return ONLY the comma-separated asset keys - no explanations, no extra text.`,
 
         // list_runs: type-coerce limit + time filters, remap job name filter and cursor
         if (params.operation === 'list_runs') {
-          if (params.limit != null && params.limit !== '') result.limit = Number(params.limit)
+          result.limit = toFiniteNumber(params.limit)
           result.jobName = params.listRunsJobName || undefined
-          if (params.createdAfter != null && params.createdAfter !== '')
-            result.createdAfter = Number(params.createdAfter)
-          if (params.createdBefore != null && params.createdBefore !== '')
-            result.createdBefore = Number(params.createdBefore)
+          result.createdAfter = toFiniteNumber(params.createdAfter)
+          result.createdBefore = toFiniteNumber(params.createdBefore)
           result.cursor = params.runsCursor || undefined
         }
 
         // get_run_logs: remap logsLimit → limit
         if (params.operation === 'get_run_logs') {
-          if (params.logsLimit != null && params.logsLimit !== '')
-            result.limit = Number(params.logsLimit)
+          result.limit = toFiniteNumber(params.logsLimit)
         }
 
         // reexecute_run: remap runId → parentRunId
@@ -506,8 +510,7 @@ Return ONLY the comma-separated asset keys - no explanations, no extra text.`,
         // list_assets: type-coerce limit and remap prefix/cursor
         if (params.operation === 'list_assets') {
           result.prefix = params.assetPrefix || undefined
-          if (params.assetsLimit != null && params.assetsLimit !== '')
-            result.limit = Number(params.assetsLimit)
+          result.limit = toFiniteNumber(params.assetsLimit)
           result.cursor = params.assetsCursor || undefined
         }
 

apps/sim/tools/dagster/list_assets.ts

@@ -8,6 +8,9 @@ import {
 } from '@/tools/dagster/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Default page size applied when the caller omits `limit`, so paging stays bounded and `hasMore` is meaningful. */
+const DEFAULT_LIST_ASSETS_LIMIT = 100
+
 /** Shape of each asset node in the `assetsOrError` → `AssetConnection.nodes` selection set. */
 interface DagsterAssetGraphqlNode {
   key: { path: string[] }
@@ -69,7 +72,7 @@ export const listAssetsTool: ToolConfig<DagsterListAssetsParams, DagsterListAsse
       type: 'number',
       required: false,
       visibility: 'user-or-llm',
-      description: 'Maximum number of assets to return (optional)',
+      description: 'Maximum number of assets to return per page (default 100)',
     },
   },
 
@@ -78,10 +81,11 @@ export const listAssetsTool: ToolConfig<DagsterListAssetsParams, DagsterListAsse
     method: 'POST',
     headers: (params) => dagsterRequestHeaders(params),
     body: (params) => {
-      const variables: Record<string, unknown> = {}
+      const variables: Record<string, unknown> = {
+        limit: params.limit ?? DEFAULT_LIST_ASSETS_LIMIT,
+      }
       if (params.prefix) variables.prefix = parseAssetKeyPath(params.prefix)
       if (params.cursor) variables.cursor = params.cursor
-      if (params.limit != null) variables.limit = params.limit
       return { query: LIST_ASSETS_QUERY, variables }
     },
   },
@@ -103,12 +107,13 @@ export const listAssetsTool: ToolConfig<DagsterListAssetsParams, DagsterListAsse
       path: node.key.path,
     }))
 
+    const limit = params?.limit ?? DEFAULT_LIST_ASSETS_LIMIT
     return {
       success: true,
       output: {
         assets,
         cursor: result.cursor ?? null,
-        hasMore: params?.limit != null && assets.length >= params.limit,
+        hasMore: assets.length >= limit,
       },
     }
   },