Skip to content

Commit 68faa42

Browse files
committed
fix(integrations): address RB2B PR review
- email_to_activity now has its own plaintext Email field (canonicalParamId) instead of sharing the Email-or-MD5 input, since it does not accept MD5 hashes - RB2BIcon uses useId() for its clipPath id instead of a hardcoded id, matching the convention used by other icons
1 parent 9ddd15d commit 68faa42

3 files changed

Lines changed: 19 additions & 6 deletions

File tree

apps/docs/components/icons.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1575,9 +1575,11 @@ export function ExaAIIcon(props: SVGProps<SVGSVGElement>) {
15751575
}
15761576

15771577
export function RB2BIcon(props: SVGProps<SVGSVGElement>) {
1578+
const id = useId()
1579+
const clipId = `rb2b_clip_${id}`
15781580
return (
15791581
<svg viewBox='0 0 165 48' fill='none' xmlns='http://www.w3.org/2000/svg' {...props}>
1580-
<g clipPath='url(#clip0_551_23712)'>
1582+
<g clipPath={`url(#${clipId})`}>
15811583
<path d='M95.975 8.40234H87.5703V16.8057H95.975V8.40234Z' fill='#0C1316' />
15821584
<path d='M121.405 8.40234H113V16.8057H121.405V8.40234Z' fill='#0C1316' />
15831585
<path d='M112.998 16.8066H104.594V25.21H112.998V16.8066Z' fill='#0C1316' />
@@ -1606,7 +1608,7 @@ export function RB2BIcon(props: SVGProps<SVGSVGElement>) {
16061608
<path d='M38.7953 8.40234H30.3906V19.7973H38.7953V8.40234Z' fill='#0C1316' />
16071609
</g>
16081610
<defs>
1609-
<clipPath id='clip0_551_23712'>
1611+
<clipPath id={clipId}>
16101612
<rect width='165' height='48' fill='white' />
16111613
</clipPath>
16121614
</defs>

apps/sim/blocks/blocks/rb2b.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const EMAIL_OPERATIONS = [
88
'hem_to_best_linkedin',
99
'hem_to_linkedin',
1010
'hem_to_maid',
11-
'email_to_activity',
1211
]
1312

1413
const LINKEDIN_OPERATIONS = [
@@ -80,13 +79,23 @@ export const RB2BBlock: BlockConfig<Rb2bResponse> = {
8079
condition: { field: 'operation', value: 'ip_to_hem' },
8180
},
8281
{
83-
id: 'email',
82+
id: 'emailOrHash',
8483
title: 'Email or MD5 Hash',
8584
type: 'short-input',
85+
canonicalParamId: 'email',
8686
placeholder: 'jane@example.com or an MD5 hash',
8787
condition: { field: 'operation', value: EMAIL_OPERATIONS },
8888
required: { field: 'operation', value: EMAIL_OPERATIONS },
8989
},
90+
{
91+
id: 'emailAddress',
92+
title: 'Email Address',
93+
type: 'short-input',
94+
canonicalParamId: 'email',
95+
placeholder: 'jane@example.com',
96+
condition: { field: 'operation', value: 'email_to_activity' },
97+
required: { field: 'operation', value: 'email_to_activity' },
98+
},
9099
{
91100
id: 'linkedin_slug',
92101
title: 'LinkedIn Slug or URL',

apps/sim/components/icons.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1575,9 +1575,11 @@ export function ExaAIIcon(props: SVGProps<SVGSVGElement>) {
15751575
}
15761576

15771577
export function RB2BIcon(props: SVGProps<SVGSVGElement>) {
1578+
const id = useId()
1579+
const clipId = `rb2b_clip_${id}`
15781580
return (
15791581
<svg viewBox='0 0 165 48' fill='none' xmlns='http://www.w3.org/2000/svg' {...props}>
1580-
<g clipPath='url(#clip0_551_23712)'>
1582+
<g clipPath={`url(#${clipId})`}>
15811583
<path d='M95.975 8.40234H87.5703V16.8057H95.975V8.40234Z' fill='#0C1316' />
15821584
<path d='M121.405 8.40234H113V16.8057H121.405V8.40234Z' fill='#0C1316' />
15831585
<path d='M112.998 16.8066H104.594V25.21H112.998V16.8066Z' fill='#0C1316' />
@@ -1606,7 +1608,7 @@ export function RB2BIcon(props: SVGProps<SVGSVGElement>) {
16061608
<path d='M38.7953 8.40234H30.3906V19.7973H38.7953V8.40234Z' fill='#0C1316' />
16071609
</g>
16081610
<defs>
1609-
<clipPath id='clip0_551_23712'>
1611+
<clipPath id={clipId}>
16101612
<rect width='165' height='48' fill='white' />
16111613
</clipPath>
16121614
</defs>

0 commit comments

Comments
 (0)