fix(autolayout): harden note overlap resolution against resize and non-finite positions

Author: waleedlatif1

apps/sim/lib/workflows/autolayout/utils.test.ts

@@ -114,6 +114,31 @@ describe('resolveNoteOverlaps', () => {
     expect(blocks.b.position).toEqual({ x: 500, y: 150 })
   })
 
+  it('never produces non-finite coordinates when a block has a NaN position', () => {
+    const blocks: Record<string, BlockState> = {
+      bad: createBlock('bad', 'agent', { x: Number.NaN, y: Number.NaN }),
+      a: createBlock('a', 'agent', { x: 150, y: 150 }),
+      note: createBlock(
+        'note',
+        'note',
+        { x: 150, y: 150 },
+        {
+          height: 120,
+          layout: { measuredHeight: 120 },
+        }
+      ),
+    }
+
+    resolveNoteOverlaps(blocks, DEFAULT_VERTICAL_SPACING)
+
+    // The corrupted block is ignored; the note still relocates off block "a"
+    // using only finite coordinates.
+    expect(Number.isFinite(blocks.note.position.x)).toBe(true)
+    expect(Number.isFinite(blocks.note.position.y)).toBe(true)
+    expect(blocks.note.position.x).toBe(150)
+    expect(blocks.note.position.y).toBeGreaterThan(150)
+  })
+
   describe('targeted mode (previousBlocks)', () => {
     it('relocates a note when a block was moved onto it', () => {
       const previousBlocks: Record<string, BlockState> = {

apps/sim/lib/workflows/autolayout/utils.ts

@@ -357,7 +357,6 @@ export function hasFinitePosition(block: BlockState): boolean {
 function noteOverlappedBlockBefore(
   previousBlocks: Record<string, BlockState>,
   noteId: string,
-  noteDimensions: { width: number; height: number },
   blockId: string
 ): boolean {
   const previousNote = previousBlocks[noteId]
@@ -368,7 +367,9 @@ function noteOverlappedBlockBefore(
   // so it could not have overlapped anything before this pass.
   if (!hasFinitePosition(previousNote) || !hasFinitePosition(previousBlock)) return false
 
-  const noteBox = createBoundingBox(previousNote.position, noteDimensions)
+  // Derive dimensions from the prior blocks so a resize between passes does not
+  // pair new dimensions with the old position.
+  const noteBox = createBoundingBox(previousNote.position, getNoteDimensions(previousNote))
   const blockBox = createBoundingBox(previousBlock.position, getBlockMetrics(previousBlock))
   return boxesOverlap(blockBox, noteBox)
 }
@@ -415,7 +416,9 @@ export function resolveNoteOverlaps(
 
     for (const id of groupIds) {
       const block = blocks[id]
-      if (!block) continue
+      // Skip non-finite positions so corrupted coordinates never propagate into
+      // minX / maxBottom (and therefore into relocated note positions).
+      if (!block || !hasFinitePosition(block)) continue
 
       if (block.type === NOTE_BLOCK_TYPE) {
         noteIds.push(id)
@@ -450,7 +453,7 @@ export function resolveNoteOverlaps(
       const needsRelocation = obstacles.some(({ id: blockId, box }) => {
         if (!boxesOverlap(box, noteBox)) return false
         if (previousBlocks) {
-          return !noteOverlappedBlockBefore(previousBlocks, id, dimensions, blockId)
+          return !noteOverlappedBlockBefore(previousBlocks, id, blockId)
         }
         return true
       })