perf improvements

Author: icecrasher321

apps/sim/app/api/workspaces/[id]/files/download/route.ts

@@ -10,9 +10,12 @@ import {
   listWorkspaceFileFolders,
   listWorkspaceFiles,
 } from '@/lib/uploads/contexts/workspace'
+import { formatFileSize } from '@/lib/uploads/utils/file-utils'
 import { verifyWorkspaceMembership } from '@/app/api/workflows/utils'
 
 const logger = createLogger('WorkspaceFilesDownloadAPI')
+const MAX_ZIP_DOWNLOAD_FILES = 100
+const MAX_ZIP_DOWNLOAD_BYTES = 250 * 1024 * 1024
 
 function safeZipPath(path: string): string {
   return path
@@ -76,6 +79,25 @@ export const GET = withRouteHandler(
         return NextResponse.json({ error: 'No files selected for download' }, { status: 400 })
       }
 
+      if (filesToZip.length > MAX_ZIP_DOWNLOAD_FILES) {
+        return NextResponse.json(
+          {
+            error: `Too many files selected for download. Select ${MAX_ZIP_DOWNLOAD_FILES} or fewer files.`,
+          },
+          { status: 413 }
+        )
+      }
+
+      const totalBytes = filesToZip.reduce((sum, file) => sum + file.size, 0)
+      if (totalBytes > MAX_ZIP_DOWNLOAD_BYTES) {
+        return NextResponse.json(
+          {
+            error: `Selected files total ${formatFileSize(totalBytes)}, which exceeds the ${formatFileSize(MAX_ZIP_DOWNLOAD_BYTES)} download limit.`,
+          },
+          { status: 413 }
+        )
+      }
+
       const zip = new JSZip()
       const usedPaths = new Set<string>()
       for (const file of filesToZip) {

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -414,6 +414,14 @@ export function Files() {
           owner: ownerCell(file.uploadedBy, members),
           updated: timeCell(file.updatedAt),
         },
+        sortValues: {
+          name: file.name,
+          size: file.size,
+          type: formatFileType(file.type, file.name),
+          created: new Date(file.uploadedAt).getTime(),
+          updated: new Date(file.updatedAt).getTime(),
+          owner: members?.find((m) => m.userId === file.uploadedBy)?.name ?? '',
+        },
       }
       return row
     })

apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts

@@ -217,6 +217,37 @@ async function mapFolderWithPath(
   return mapFolder(folder, new Map([[folder.id, path]]))
 }
 
+export async function getWorkspaceFileFolderPath(
+  workspaceId: string,
+  folderId: string,
+  options?: { includeDeleted?: boolean }
+): Promise<string | null> {
+  const folder = await getRawWorkspaceFileFolder(workspaceId, folderId, options)
+  return folder ? buildWorkspaceFileFolderPath(workspaceId, folder, options) : null
+}
+
+export async function findWorkspaceFileFolderIdByPath(
+  workspaceId: string,
+  pathSegments: string[]
+): Promise<string | null> {
+  let parentId: string | null = null
+
+  for (const rawSegment of pathSegments) {
+    let name: string
+    try {
+      name = normalizeWorkspaceFileItemName(rawSegment, 'Folder')
+    } catch {
+      return null
+    }
+
+    const folder = await findRawWorkspaceFileFolderByName(workspaceId, name, parentId)
+    if (!folder) return null
+    parentId = folder.id
+  }
+
+  return parentId
+}
+
 export async function listWorkspaceFileFolders(
   workspaceId: string,
   options?: { scope?: WorkspaceFileFolderScope }

apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts

@@ -33,6 +33,8 @@ import {
   assertWorkspaceFileFolderTarget,
   buildWorkspaceFileFolderPathMap,
   fileNameExistsInWorkspaceFolder,
+  findWorkspaceFileFolderIdByPath,
+  getWorkspaceFileFolderPath,
   listWorkspaceFileFolders,
   normalizeWorkspaceFileItemName,
 } from './workspace-file-folder-manager'
@@ -565,6 +567,24 @@ function mapWorkspaceFileRecord(
   }
 }
 
+async function mapSingleWorkspaceFileRecord(
+  file: typeof workspaceFiles.$inferSelect,
+  workspaceId: string
+): Promise<WorkspaceFileRecord> {
+  if (!file.folderId) {
+    return mapWorkspaceFileRecord(file, workspaceId, new Map())
+  }
+
+  const folderPath = await getWorkspaceFileFolderPath(workspaceId, file.folderId, {
+    includeDeleted: true,
+  })
+  return mapWorkspaceFileRecord(
+    file,
+    workspaceId,
+    folderPath ? new Map([[file.folderId, folderPath]]) : new Map()
+  )
+}
+
 /**
  * Look up a single active workspace file by its original name.
  * Returns the record if found, or null if no matching file exists.
@@ -592,9 +612,7 @@ export async function getWorkspaceFileByName(
 
   if (files.length === 0) return null
 
-  const folders = await listWorkspaceFileFolders(workspaceId, { scope: 'all' })
-  const folderPaths = buildWorkspaceFileFolderPathMap(folders)
-  return mapWorkspaceFileRecord(files[0], workspaceId, folderPaths)
+  return mapSingleWorkspaceFileRecord(files[0], workspaceId)
 }
 
 /**
@@ -728,13 +746,43 @@ export function findWorkspaceFileRecord(
   return files.find((file) => normalizeVfsSegment(file.name) === segmentKey) ?? null
 }
 
+async function getWorkspaceFileByExactReference(
+  workspaceId: string,
+  fileReference: string
+): Promise<WorkspaceFileRecord | null> {
+  const segments = fileReference
+    .split('/')
+    .map((segment) => segment.trim())
+    .filter(Boolean)
+
+  if (segments.length === 0) return null
+  if (segments.length === 1) {
+    return getWorkspaceFileByName(workspaceId, segments[0], { folderId: null })
+  }
+
+  const folderId = await findWorkspaceFileFolderIdByPath(workspaceId, segments.slice(0, -1))
+  return folderId ? getWorkspaceFileByName(workspaceId, segments.at(-1) ?? '', { folderId }) : null
+}
+
 /**
  * Resolve a workspace file record from either its id or a VFS/name reference.
  */
 export async function resolveWorkspaceFileReference(
   workspaceId: string,
   fileReference: string
 ): Promise<WorkspaceFileRecord | null> {
+  const normalizedReference = normalizeWorkspaceFileReference(fileReference)
+  if (normalizedReference.startsWith('wf_')) {
+    const file = await getWorkspaceFile(workspaceId, normalizedReference)
+    if (file) return file
+  }
+
+  const exactReferenceFile = await getWorkspaceFileByExactReference(
+    workspaceId,
+    normalizedReference
+  )
+  if (exactReferenceFile) return exactReferenceFile
+
   const files = await listWorkspaceFiles(workspaceId)
   return findWorkspaceFileRecord(files, fileReference)
 }
@@ -770,9 +818,7 @@ export async function getWorkspaceFile(
 
     if (files.length === 0) return null
 
-    const folders = await listWorkspaceFileFolders(workspaceId, { scope: 'all' })
-    const folderPaths = buildWorkspaceFileFolderPathMap(folders)
-    return mapWorkspaceFileRecord(files[0], workspaceId, folderPaths)
+    return mapSingleWorkspaceFileRecord(files[0], workspaceId)
   } catch (error) {
     logger.error(`Failed to get workspace file ${fileId}:`, error)
     return null