Commit 9a24aa9
committed
fix(undo-redo): address PR review feedback
- collaborativeBatchSetSubblockValues: capture each field's real prior value
before mutating instead of recording before: update.expectedValue, which was
undefined when a caller omitted expectedValue (would undo a field to undefined)
- List the stable recordSubflowFieldUpdate helper in the subflow methods'
dependency arrays
- Document that a multi-block batch undo reveals only its first block1 parent 73e563b commit 9a24aa9
2 files changed
Lines changed: 15 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1684 | 1684 | | |
1685 | 1685 | | |
1686 | 1686 | | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
1687 | 1696 | | |
1688 | 1697 | | |
1689 | 1698 | | |
| |||
1707 | 1716 | | |
1708 | 1717 | | |
1709 | 1718 | | |
1710 | | - | |
1711 | | - | |
1712 | | - | |
1713 | | - | |
1714 | | - | |
1715 | | - | |
1716 | | - | |
1717 | | - | |
1718 | | - | |
| 1719 | + | |
1719 | 1720 | | |
1720 | 1721 | | |
1721 | 1722 | | |
| |||
1953 | 1954 | | |
1954 | 1955 | | |
1955 | 1956 | | |
1956 | | - | |
| 1957 | + | |
1957 | 1958 | | |
1958 | 1959 | | |
1959 | 1960 | | |
| |||
2054 | 2055 | | |
2055 | 2056 | | |
2056 | 2057 | | |
2057 | | - | |
| 2058 | + | |
2058 | 2059 | | |
2059 | 2060 | | |
2060 | 2061 | | |
| |||
2093 | 2094 | | |
2094 | 2095 | | |
2095 | 2096 | | |
2096 | | - | |
| 2097 | + | |
2097 | 2098 | | |
2098 | 2099 | | |
2099 | 2100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
0 commit comments