fix(oauth): follower last-chance read after poll deadline

Author: waleedlatif1

apps/sim/lib/concurrency/__tests__/leader-lock.test.ts

@@ -117,6 +117,28 @@ describe('withLeaderLock', () => {
     expect(onFollower.mock.calls.length).toBeGreaterThanOrEqual(2)
   })
 
+  it('follower does a final read after timeout to catch a just-finished leader', async () => {
+    redisConfigMockFns.mockAcquireLock.mockResolvedValueOnce(false)
+
+    let polls = 0
+    const onFollower = vi.fn(async () => {
+      polls += 1
+      // Return null during the poll loop, value on the post-deadline read.
+      if (polls <= 2) return null
+      return 'late-leader'
+    })
+
+    const result = await withLeaderLock<string>({
+      key: 'k',
+      pollIntervalMs: 5,
+      maxWaitMs: 12,
+      onLeader: async () => 'should-not-run',
+      onFollower,
+    })
+
+    expect(result).toBe('late-leader')
+  })
+
   it('follower returns null after timeout', async () => {
     redisConfigMockFns.mockAcquireLock.mockResolvedValueOnce(false)
 

apps/sim/lib/concurrency/leader-lock.ts

@@ -64,6 +64,10 @@ export async function withLeaderLock<T>(opts: LeaderLockOptions<T>): Promise<T |
     if (value !== null) return value
   }
 
+  // The leader may have persisted between our final poll and now; one last check.
+  const lastChance = await onFollower()
+  if (lastChance !== null) return lastChance
+
   logger.warn('Follower timed out waiting for leader', { key, maxWaitMs })
   return null
 }