fix(integrations): harden Wiza reveal polling, soften enrichment getCost guards

Address Greptile + Cursor Bugbot review on #4777: return explicit failures from the Wiza individual_reveal poller instead of throwing (thrown errors were swallowed into a false queued success), short-circuit when the initial reveal is already terminal, tolerate transient 5xx/429 during polling, and return 0 (not throw) from Findymail getCost when the contacts/employees array is absent.

Author: TheodoreSpeaks

apps/sim/tools/enrichment-hosting.test.ts

@@ -186,4 +186,85 @@ describe('Wiza hosted key pricing', () => {
     expect((result.output as any).email).toBe('a@b.com')
     expect((result.output as any).status).toBe('finished')
   })
+
+  it('returns immediately without polling when the initial reveal is already terminal', async () => {
+    const fetchMock = vi.fn()
+    vi.stubGlobal('fetch', fetchMock)
+
+    const initial = {
+      success: true as const,
+      output: {
+        id: 123,
+        status: 'finished',
+        is_complete: true,
+        email: 'a@b.com',
+        email_status: 'valid',
+        emails: [],
+        phones: [],
+      } as any,
+    }
+    const result = await wizaIndividualRevealTool.postProcess!(
+      initial as any,
+      { apiKey: 'k', enrichment_level: 'full' } as any,
+      vi.fn()
+    )
+
+    expect(fetchMock).not.toHaveBeenCalled()
+    expect(result.success).toBe(true)
+    expect((result.output as any).email).toBe('a@b.com')
+  })
+
+  it('retries transient poll errors and still resolves on a later finished response', async () => {
+    vi.useFakeTimers()
+    const fetchMock = vi
+      .fn()
+      .mockResolvedValueOnce(new Response('busy', { status: 503 }))
+      .mockResolvedValueOnce(new Response('rate limited', { status: 429 }))
+      .mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            data: { id: 1, status: 'finished', email: 'a@b.com', email_status: 'valid', emails: [], phones: [] },
+          }),
+          { status: 200, headers: { 'Content-Type': 'application/json' } }
+        )
+      )
+    vi.stubGlobal('fetch', fetchMock)
+
+    const initial = {
+      success: true as const,
+      output: { id: 1, status: 'queued', is_complete: false } as any,
+    }
+    const promise = wizaIndividualRevealTool.postProcess!(
+      initial as any,
+      { apiKey: 'k', enrichment_level: 'full' } as any,
+      vi.fn()
+    )
+    await vi.advanceTimersByTimeAsync(6000)
+    const result = await promise
+
+    expect(fetchMock).toHaveBeenCalledTimes(3)
+    expect(result.success).toBe(true)
+    expect((result.output as any).email).toBe('a@b.com')
+  })
+
+  it('returns an explicit failure (not a queued success) after repeated poll errors', async () => {
+    vi.useFakeTimers()
+    const fetchMock = vi.fn().mockResolvedValue(new Response('error', { status: 500 }))
+    vi.stubGlobal('fetch', fetchMock)
+
+    const initial = {
+      success: true as const,
+      output: { id: 1, status: 'queued', is_complete: false } as any,
+    }
+    const promise = wizaIndividualRevealTool.postProcess!(
+      initial as any,
+      { apiKey: 'k', enrichment_level: 'full' } as any,
+      vi.fn()
+    )
+    await vi.advanceTimersByTimeAsync(6000)
+    const result = await promise
+
+    expect(result.success).toBe(false)
+    expect((result.output as any).status).toBe('queued')
+  })
 })

apps/sim/tools/findymail/find_emails_by_domain.ts

@@ -17,8 +17,9 @@ export const findEmailsByDomainTool: ToolConfig<
   version: '1.0.0',
 
   hosting: findymailHosting<FindymailFindEmailsByDomainParams>((_params, output) => {
+    // No contacts array means no verified contacts returned — no charge.
     if (!Array.isArray(output.contacts)) {
-      throw new Error('Findymail find emails by domain response missing contacts array')
+      return 0
     }
     // 1 finder credit per verified contact returned.
     return output.contacts.length

apps/sim/tools/findymail/find_employees.ts

@@ -17,8 +17,9 @@ export const findEmployeesTool: ToolConfig<
   version: '1.0.0',
 
   hosting: findymailHosting<FindymailFindEmployeesParams>((_params, output) => {
+    // No employees array means no contacts found — no charge.
     if (!Array.isArray(output.employees)) {
-      throw new Error('Findymail find employees response missing employees array')
+      return 0
     }
     // 1 finder credit per contact found.
     return output.employees.length

apps/sim/tools/wiza/individual_reveal.ts

@@ -9,6 +9,13 @@ import type {
 
 const POLL_INTERVAL_MS = 2000
 const MAX_POLL_TIME_MS = 120000
+/** Tolerate brief Wiza outages while polling before giving up on an already-started reveal. */
+const MAX_CONSECUTIVE_POLL_ERRORS = 3
+
+/** Whether a reveal payload has reached a terminal state and no longer needs polling. */
+function isTerminalReveal(d: Record<string, unknown>): boolean {
+  return d.status === 'finished' || d.status === 'failed' || d.is_complete === true
+}
 
 /** Map a Wiza individual-reveal payload (`data` object) to the tool output shape. */
 function mapRevealData(d: Record<string, unknown>): WizaIndividualRevealData {
@@ -192,12 +199,25 @@ export const wizaIndividualRevealTool: ToolConfig<
   postProcess: async (result, params) => {
     if (!result.success) return result
 
+    // Wiza can resolve synchronously (e.g. a cache hit) — the initial POST payload is
+    // already mapped, so skip polling when it is terminal.
+    if (isTerminalReveal(result.output)) {
+      return { success: result.output.status !== 'failed', output: result.output }
+    }
+
     const revealId = result.output.id
     if (revealId == null) {
-      throw new Error('Wiza individual reveal did not return an id')
+      // Return an explicit failure rather than throwing: a thrown error here is swallowed
+      // by the executor and masked as the queued (incomplete) success result.
+      return {
+        success: false,
+        error: 'Wiza individual reveal did not return an id',
+        output: result.output,
+      }
     }
 
     let elapsedTime = 0
+    let consecutiveErrors = 0
     while (elapsedTime < MAX_POLL_TIME_MS) {
       await sleep(POLL_INTERVAL_MS)
       elapsedTime += POLL_INTERVAL_MS
@@ -213,22 +233,37 @@ export const wizaIndividualRevealTool: ToolConfig<
       )
 
       if (!statusResponse.ok) {
-        const errorText = await statusResponse.text()
-        throw new Error(`Wiza API error: ${statusResponse.status} - ${errorText}`)
+        // The reveal is already started (and billed by Wiza), so tolerate brief outages and
+        // retry rather than aborting the whole window on a single transient 5xx/429.
+        consecutiveErrors += 1
+        if (consecutiveErrors >= MAX_CONSECUTIVE_POLL_ERRORS) {
+          const errorText = await statusResponse.text().catch(() => '')
+          return {
+            success: false,
+            error: `Wiza API error: ${statusResponse.status} - ${errorText}`,
+            output: result.output,
+          }
+        }
+        continue
       }
+      consecutiveErrors = 0
 
       const json = await statusResponse.json()
       const data = json.data ?? {}
 
-      if (data.status === 'finished' || data.status === 'failed' || data.is_complete === true) {
+      if (isTerminalReveal(data)) {
         return {
           success: data.status !== 'failed',
           output: mapRevealData(data),
         }
       }
     }
 
-    throw new Error('Wiza individual reveal did not complete within the polling window')
+    return {
+      success: false,
+      error: 'Wiza individual reveal did not complete within the polling window',
+      output: result.output,
+    }
   },
 
   outputs: {