fix(health): accept query params in health checks

Author: byigitt

apps/sim/app/api/health/route.test.ts

@@ -1,6 +1,7 @@
 /**
  * @vitest-environment node
  */
+import appPackage from '@/package.json'
 import { NextRequest } from 'next/server'
 import { afterEach, describe, expect, it } from 'vitest'
 import { GET } from '@/app/api/health/route'
@@ -29,6 +30,12 @@ describe('GET /api/health', () => {
     })
   })
 
+  it('accepts query parameters from health-checking clients', async () => {
+    const response = await GET(new NextRequest('http://localhost/api/health?_=123'))
+
+    expect(response.status).toBe(200)
+  })
+
   it('falls back to the package version when runtime metadata is not provided', async () => {
     process.env.APP_VERSION = ''
     process.env.NEXT_PUBLIC_APP_VERSION = ''
@@ -42,7 +49,7 @@ describe('GET /api/health', () => {
     await expect(response.json()).resolves.toEqual({
       status: 'ok',
       timestamp: expect.any(String),
-      version: '0.1.0',
+      version: appPackage.version,
       commit: null,
     })
   })

apps/sim/app/api/health/route.ts

@@ -20,7 +20,6 @@ function getAppCommit(): string | null {
 export async function GET(request: NextRequest): Promise<Response> {
   const parsed = await parseRequest(healthContract, request, {})
   if (!parsed.success) return parsed.response
-
   return NextResponse.json(
     {
       status: 'ok',

apps/sim/lib/api/contracts/health.ts

@@ -1,7 +1,7 @@
 import { z } from 'zod'
-import { noInputSchema } from '@/lib/api/contracts/primitives'
 import { defineRouteContract } from '@/lib/api/contracts/types'
 
+const healthQuerySchema = z.object({}).passthrough()
 export const healthResponseSchema = z.object({
   status: z.literal('ok'),
   timestamp: z.string(),
@@ -14,7 +14,7 @@ export type HealthResponse = z.output<typeof healthResponseSchema>
 export const healthContract = defineRouteContract({
   method: 'GET',
   path: '/api/health',
-  query: noInputSchema,
+  query: healthQuerySchema,
   response: {
     mode: 'json',
     schema: healthResponseSchema,