Skip to content

Commit e0882cd

Browse files
fix(tables): drop out-of-scope abort/timeout fields from cell catch
The main catch logged `aborted`/`timedOut` from `abortSignal`/`timeoutController`, but those are declared inside the outer try block (the inner try around executeWorkflow is try/finally, so this catch belongs to the outer try) and are not in scope in the catch — `next build`'s type-check failed with "Cannot find name 'abortSignal'". Local incremental `tsc --noEmit` had skipped the file and falsely passed; the Cursor/Greptile reviewers flagged this correctly. Removed the two fields. Abort/timeout is still surfaced via `cause: describeError(err)` (an aborted run shows `name: 'AbortError'` / the timeout message), so no diagnostic signal is lost. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8812154 commit e0882cd

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

apps/sim/background/workflow-column-execution.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,8 +739,6 @@ async function runWorkflowAndWriteTerminal(
739739
executionId,
740740
cause: describeError(err),
741741
retryable: isRetryableCellError(err),
742-
aborted: abortSignal.aborted,
743-
timedOut: timeoutController.isTimedOut(),
744742
}
745743
)
746744
terminalWritten = true

0 commit comments

Comments
 (0)