fix(integrations): address incident workflow review fixes

Author: waleedlatif1

apps/sim/tools/incidentio/schedule_entries_list.ts

@@ -44,20 +44,19 @@ export const scheduleEntriesListTool: ToolConfig<
 
   request: {
     url: (params) => {
-      const queryParams: string[] = []
+      const url = new URL('https://api.incident.io/v2/schedule_entries')
 
-      queryParams.push(`schedule_id=${params.schedule_id}`)
+      url.searchParams.set('schedule_id', params.schedule_id.trim())
 
       if (params.entry_window_start) {
-        queryParams.push(`entry_window_start=${encodeURIComponent(params.entry_window_start)}`)
+        url.searchParams.set('entry_window_start', params.entry_window_start)
       }
 
       if (params.entry_window_end) {
-        queryParams.push(`entry_window_end=${encodeURIComponent(params.entry_window_end)}`)
+        url.searchParams.set('entry_window_end', params.entry_window_end)
       }
 
-      const queryString = queryParams.length > 0 ? `?${queryParams.join('&')}` : ''
-      return `https://api.incident.io/v2/schedule_entries${queryString}`
+      return url.toString()
     },
     method: 'GET',
     headers: (params) => ({

apps/sim/tools/incidentio/types.ts

@@ -175,10 +175,31 @@ export const INCIDENTIO_FOLLOW_UP_OUTPUT: OutputProperty = {
 export const INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES = {
   id: { type: 'string', description: 'Workflow ID' },
   name: { type: 'string', description: 'Workflow name' },
+  trigger: { type: 'string', description: 'Workflow trigger' },
+  once_for: { type: 'array', description: 'Fields that make the workflow run once' },
+  version: { type: 'number', description: 'Workflow version' },
+  expressions: { type: 'array', description: 'Workflow expressions' },
+  condition_groups: { type: 'array', description: 'Workflow condition groups' },
+  steps: { type: 'array', description: 'Workflow steps' },
+  include_private_incidents: {
+    type: 'boolean',
+    description: 'Whether the workflow includes private incidents',
+  },
+  include_private_escalations: {
+    type: 'boolean',
+    description: 'Whether the workflow includes private escalations',
+  },
+  runs_on_incident_modes: { type: 'array', description: 'Incident modes the workflow runs on' },
+  continue_on_step_error: {
+    type: 'boolean',
+    description: 'Whether execution continues after a step error',
+  },
+  runs_on_incidents: { type: 'string', description: 'Incident lifecycle filter' },
   state: { type: 'string', description: 'Workflow state (active, draft, disabled)' },
+  delay: { type: 'object', description: 'Workflow delay configuration', optional: true },
   folder: { type: 'string', description: 'Workflow folder', optional: true },
-  created_at: { type: 'string', description: 'When the workflow was created', optional: true },
-  updated_at: { type: 'string', description: 'When the workflow was last updated', optional: true },
+  runs_from: { type: 'string', description: 'When the workflow runs from', optional: true },
+  shortform: { type: 'string', description: 'Workflow shortform identifier', optional: true },
 } as const satisfies Record<string, OutputProperty>
 
 /**
@@ -499,13 +520,25 @@ export interface IncidentioFollowUpsShowResponse extends ToolResponse {
 }
 
 // Workflow types
-interface Workflow {
+export interface Workflow {
   id: string
   name: string
+  trigger: string
+  once_for: unknown[]
+  version: number
+  expressions: unknown[]
+  condition_groups: unknown[]
+  steps: unknown[]
+  include_private_incidents: boolean
+  include_private_escalations: boolean
+  runs_on_incident_modes: string[]
+  continue_on_step_error: boolean
+  runs_on_incidents: 'newly_created' | 'newly_created_and_active' | 'active' | 'all'
   state: 'active' | 'draft' | 'disabled'
+  delay?: unknown
   folder?: string
-  created_at?: string
-  updated_at?: string
+  runs_from?: string
+  shortform?: string
 }
 
 // Workflows List tool types

apps/sim/tools/incidentio/utils.ts

@@ -1,7 +1,29 @@
+import type { Workflow } from '@/tools/incidentio/types'
+
 function getJsonParseErrorMessage(error: unknown): string {
   return error instanceof Error ? error.message : String(error)
 }
 
+function toStringValue(value: unknown): string {
+  return typeof value === 'string' ? value : String(value ?? '')
+}
+
+function toOptionalStringValue(value: unknown): string | undefined {
+  return typeof value === 'string' && value ? value : undefined
+}
+
+function toNumberValue(value: unknown): number {
+  return typeof value === 'number' ? value : Number(value ?? 0)
+}
+
+function toBooleanValue(value: unknown): boolean {
+  return value === true
+}
+
+function toArrayValue<T = unknown>(value: unknown): T[] {
+  return Array.isArray(value) ? (value as T[]) : []
+}
+
 export function parseIncidentioJsonParam(
   jsonString: string | undefined,
   paramName: string,
@@ -26,3 +48,26 @@ export function parseRequiredIncidentioJsonParam(
 
   return parseIncidentioJsonParam(jsonString, paramName, undefined)
 }
+
+export function mapIncidentioWorkflow(workflow: Record<string, unknown>): Workflow {
+  return {
+    id: toStringValue(workflow.id),
+    name: toStringValue(workflow.name),
+    trigger: toStringValue(workflow.trigger),
+    once_for: toArrayValue(workflow.once_for),
+    version: toNumberValue(workflow.version),
+    expressions: toArrayValue(workflow.expressions),
+    condition_groups: toArrayValue(workflow.condition_groups),
+    steps: toArrayValue(workflow.steps),
+    include_private_incidents: toBooleanValue(workflow.include_private_incidents),
+    include_private_escalations: toBooleanValue(workflow.include_private_escalations),
+    runs_on_incident_modes: toArrayValue<string>(workflow.runs_on_incident_modes),
+    continue_on_step_error: toBooleanValue(workflow.continue_on_step_error),
+    runs_on_incidents: toStringValue(workflow.runs_on_incidents) as Workflow['runs_on_incidents'],
+    state: toStringValue(workflow.state) as Workflow['state'],
+    delay: workflow.delay,
+    folder: toOptionalStringValue(workflow.folder),
+    runs_from: toOptionalStringValue(workflow.runs_from),
+    shortform: toOptionalStringValue(workflow.shortform),
+  }
+}

apps/sim/tools/incidentio/workflows_create.ts

@@ -1,5 +1,6 @@
 import type { WorkflowsCreateParams, WorkflowsCreateResponse } from '@/tools/incidentio/types'
-import { parseIncidentioJsonParam } from '@/tools/incidentio/utils'
+import { INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES } from '@/tools/incidentio/types'
+import { mapIncidentioWorkflow, parseIncidentioJsonParam } from '@/tools/incidentio/utils'
 import type { ToolConfig } from '@/tools/types'
 
 export const workflowsCreateTool: ToolConfig<WorkflowsCreateParams, WorkflowsCreateResponse> = {
@@ -157,14 +158,7 @@ export const workflowsCreateTool: ToolConfig<WorkflowsCreateParams, WorkflowsCre
       success: true,
       output: {
         management_meta: data.management_meta,
-        workflow: {
-          id: data.workflow.id,
-          name: data.workflow.name,
-          state: data.workflow.state,
-          folder: data.workflow.folder,
-          created_at: data.workflow.created_at,
-          updated_at: data.workflow.updated_at,
-        },
+        workflow: mapIncidentioWorkflow(data.workflow),
       },
     }
   },
@@ -173,25 +167,7 @@ export const workflowsCreateTool: ToolConfig<WorkflowsCreateParams, WorkflowsCre
     workflow: {
       type: 'object',
       description: 'The created workflow',
-      properties: {
-        id: { type: 'string', description: 'Unique identifier for the workflow' },
-        name: { type: 'string', description: 'Name of the workflow' },
-        state: {
-          type: 'string',
-          description: 'State of the workflow (active, draft, or disabled)',
-        },
-        folder: { type: 'string', description: 'Folder the workflow belongs to', optional: true },
-        created_at: {
-          type: 'string',
-          description: 'When the workflow was created',
-          optional: true,
-        },
-        updated_at: {
-          type: 'string',
-          description: 'When the workflow was last updated',
-          optional: true,
-        },
-      },
+      properties: INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES,
     },
     management_meta: {
       type: 'json',

apps/sim/tools/incidentio/workflows_list.ts

@@ -1,4 +1,6 @@
 import type { WorkflowsListParams, WorkflowsListResponse } from '@/tools/incidentio/types'
+import { INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES } from '@/tools/incidentio/types'
+import { mapIncidentioWorkflow } from '@/tools/incidentio/utils'
 import type { ToolConfig } from '@/tools/types'
 
 export const workflowsListTool: ToolConfig<WorkflowsListParams, WorkflowsListResponse> = {
@@ -31,14 +33,10 @@ export const workflowsListTool: ToolConfig<WorkflowsListParams, WorkflowsListRes
     return {
       success: true,
       output: {
-        workflows: data.workflows.map((workflow: any) => ({
-          id: workflow.id,
-          name: workflow.name,
-          state: workflow.state,
-          folder: workflow.folder,
-          created_at: workflow.created_at,
-          updated_at: workflow.updated_at,
-        })),
+        workflows:
+          data.workflows?.map((workflow: Record<string, unknown>) =>
+            mapIncidentioWorkflow(workflow)
+          ) ?? [],
       },
     }
   },
@@ -49,25 +47,7 @@ export const workflowsListTool: ToolConfig<WorkflowsListParams, WorkflowsListRes
       description: 'List of workflows',
       items: {
         type: 'object',
-        properties: {
-          id: { type: 'string', description: 'Unique identifier for the workflow' },
-          name: { type: 'string', description: 'Name of the workflow' },
-          state: {
-            type: 'string',
-            description: 'State of the workflow (active, draft, or disabled)',
-          },
-          folder: { type: 'string', description: 'Folder the workflow belongs to', optional: true },
-          created_at: {
-            type: 'string',
-            description: 'When the workflow was created',
-            optional: true,
-          },
-          updated_at: {
-            type: 'string',
-            description: 'When the workflow was last updated',
-            optional: true,
-          },
-        },
+        properties: INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES,
       },
     },
   },

apps/sim/tools/incidentio/workflows_show.ts

@@ -1,4 +1,6 @@
 import type { WorkflowsShowParams, WorkflowsShowResponse } from '@/tools/incidentio/types'
+import { INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES } from '@/tools/incidentio/types'
+import { mapIncidentioWorkflow } from '@/tools/incidentio/utils'
 import type { ToolConfig } from '@/tools/types'
 
 export const workflowsShowTool: ToolConfig<WorkflowsShowParams, WorkflowsShowResponse> = {
@@ -38,14 +40,7 @@ export const workflowsShowTool: ToolConfig<WorkflowsShowParams, WorkflowsShowRes
       success: true,
       output: {
         management_meta: data.management_meta,
-        workflow: {
-          id: data.workflow.id,
-          name: data.workflow.name,
-          state: data.workflow.state,
-          folder: data.workflow.folder,
-          created_at: data.workflow.created_at,
-          updated_at: data.workflow.updated_at,
-        },
+        workflow: mapIncidentioWorkflow(data.workflow),
       },
     }
   },
@@ -54,25 +49,7 @@ export const workflowsShowTool: ToolConfig<WorkflowsShowParams, WorkflowsShowRes
     workflow: {
       type: 'object',
       description: 'The workflow details',
-      properties: {
-        id: { type: 'string', description: 'Unique identifier for the workflow' },
-        name: { type: 'string', description: 'Name of the workflow' },
-        state: {
-          type: 'string',
-          description: 'State of the workflow (active, draft, or disabled)',
-        },
-        folder: { type: 'string', description: 'Folder the workflow belongs to', optional: true },
-        created_at: {
-          type: 'string',
-          description: 'When the workflow was created',
-          optional: true,
-        },
-        updated_at: {
-          type: 'string',
-          description: 'When the workflow was last updated',
-          optional: true,
-        },
-      },
+      properties: INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES,
     },
     management_meta: {
       type: 'json',

apps/sim/tools/incidentio/workflows_update.ts

@@ -1,5 +1,7 @@
 import type { WorkflowsUpdateParams, WorkflowsUpdateResponse } from '@/tools/incidentio/types'
+import { INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES } from '@/tools/incidentio/types'
 import {
+  mapIncidentioWorkflow,
   parseIncidentioJsonParam,
   parseRequiredIncidentioJsonParam,
 } from '@/tools/incidentio/utils'
@@ -140,14 +142,7 @@ export const workflowsUpdateTool: ToolConfig<WorkflowsUpdateParams, WorkflowsUpd
       success: true,
       output: {
         management_meta: data.management_meta,
-        workflow: {
-          id: data.workflow.id,
-          name: data.workflow.name,
-          state: data.workflow.state,
-          folder: data.workflow.folder,
-          created_at: data.workflow.created_at,
-          updated_at: data.workflow.updated_at,
-        },
+        workflow: mapIncidentioWorkflow(data.workflow),
       },
     }
   },
@@ -156,25 +151,7 @@ export const workflowsUpdateTool: ToolConfig<WorkflowsUpdateParams, WorkflowsUpd
     workflow: {
       type: 'object',
       description: 'The updated workflow',
-      properties: {
-        id: { type: 'string', description: 'Unique identifier for the workflow' },
-        name: { type: 'string', description: 'Name of the workflow' },
-        state: {
-          type: 'string',
-          description: 'State of the workflow (active, draft, or disabled)',
-        },
-        folder: { type: 'string', description: 'Folder the workflow belongs to', optional: true },
-        created_at: {
-          type: 'string',
-          description: 'When the workflow was created',
-          optional: true,
-        },
-        updated_at: {
-          type: 'string',
-          description: 'When the workflow was last updated',
-          optional: true,
-        },
-      },
+      properties: INCIDENTIO_WORKFLOW_OUTPUT_PROPERTIES,
     },
     management_meta: {
       type: 'json',