fix(storage): address review feedback and fix env mock for CI

- Add envBoolean to the shared env test mock (createEnvMock) so config.ts's
  forcePathStyle coercion resolves — fixes failing knowledge/utils.test.ts
- Declare S3_FORCE_PATH_STYLE as z.string() (every other env var's pattern);
  it's coerced via envBoolean at the consumption site, avoiding a boolean
  type that never matches the string process.env value
- Log path-style from S3_CONFIG.forcePathStyle (envBoolean) instead of a
  separate isTruthy call, so the startup log can't disagree with the client
- Make buildObjectFallbackUrl honor forcePathStyle: virtual-hosted-style URL
  (bucket as subdomain) for R2, path-style only when forcePathStyle is set

Author: waleedlatif1

apps/sim/lib/core/config/env.ts

@@ -219,7 +219,7 @@ export const env = createEnv({
     S3_OG_IMAGES_BUCKET_NAME:              z.string().optional(),                  // S3 bucket for OpenGraph images
     S3_WORKSPACE_LOGOS_BUCKET_NAME:        z.string().optional(),                  // S3 bucket for workspace logos
     S3_ENDPOINT:                           z.string().optional(),                  // Custom endpoint for S3-compatible storage (Cloudflare R2, MinIO, Backblaze B2). Leave unset for AWS S3
-    S3_FORCE_PATH_STYLE:                   z.boolean().optional(),                 // Force path-style addressing (MinIO/Ceph RGW). Defaults to false (AWS S3, R2)
+    S3_FORCE_PATH_STYLE:                   z.string().optional(),                  // Force path-style addressing (MinIO/Ceph RGW). Defaults to false (AWS S3, R2). Coerced via envBoolean at the consumption site
 
     // Cloud Storage - Azure Blob
     AZURE_ACCOUNT_NAME:                    z.string().optional(),                  // Azure storage account name

apps/sim/lib/uploads/core/setup.server.ts

@@ -2,8 +2,13 @@ import { existsSync } from 'fs'
 import { mkdir } from 'fs/promises'
 import path, { join } from 'path'
 import { createLogger } from '@sim/logger'
-import { env, isTruthy } from '@/lib/core/config/env'
-import { getStorageProvider, USE_BLOB_STORAGE, USE_S3_STORAGE } from '@/lib/uploads/config'
+import { env } from '@/lib/core/config/env'
+import {
+  getStorageProvider,
+  S3_CONFIG,
+  USE_BLOB_STORAGE,
+  USE_S3_STORAGE,
+} from '@/lib/uploads/config'
 
 const logger = createLogger('UploadsSetup')
 
@@ -82,7 +87,7 @@ if (typeof process !== 'undefined') {
 
     if (env.S3_ENDPOINT) {
       logger.info(
-        `Using S3-compatible endpoint: ${env.S3_ENDPOINT} (path-style: ${isTruthy(env.S3_FORCE_PATH_STYLE)})`
+        `Using S3-compatible endpoint: ${env.S3_ENDPOINT} (path-style: ${S3_CONFIG.forcePathStyle})`
       )
     }
   } else {

apps/sim/lib/uploads/providers/s3/client.ts

@@ -390,13 +390,20 @@ export async function getS3MultipartPartUrls(
 
 /**
  * Build a fallback object URL for when the SDK omits `Location` on multipart
- * completion. Honors a custom `S3_CONFIG.endpoint` (R2/MinIO) with path-style
- * addressing; otherwise falls back to the AWS virtual-hosted-style host.
+ * completion. For a custom `S3_CONFIG.endpoint` it matches the configured
+ * addressing mode — path-style for MinIO/Ceph (`forcePathStyle`), virtual-hosted
+ * (bucket as a subdomain) for R2 and friends. Falls back to the AWS
+ * virtual-hosted host when no custom endpoint is set.
  */
 function buildObjectFallbackUrl(bucket: string, region: string, key: string): string {
   if (S3_CONFIG.endpoint) {
     const base = S3_CONFIG.endpoint.replace(/\/+$/, '')
-    return `${base}/${bucket}/${key}`
+    if (S3_CONFIG.forcePathStyle) {
+      return `${base}/${bucket}/${key}`
+    }
+    const url = new URL(base)
+    url.hostname = `${bucket}.${url.hostname}`
+    return `${url.origin}/${key}`
   }
   return `https://${bucket}.s3.${region}.amazonaws.com/${key}`
 }

packages/testing/src/mocks/env.mock.ts

@@ -53,6 +53,14 @@ export function createEnvMock(overrides: Record<string, string | undefined> = {}
       typeof value === 'string'
         ? value.toLowerCase() === 'false' || value === '0'
         : value === false,
+    envBoolean: (value: boolean | string | undefined | null): boolean | undefined => {
+      if (typeof value === 'boolean') return value
+      if (value === undefined || value === null || value === '') return undefined
+      const normalized = String(value).trim().toLowerCase()
+      return (
+        normalized === 'true' || normalized === '1' || normalized === 'yes' || normalized === 'on'
+      )
+    },
     envNumber: (
       value: number | string | undefined | null,
       fallback: number,