V1 build broken

[srmo]

The v1 asset for linux, named as x64 contains just a binary for arm. And trying to build it from scratch (from the v1 commit) fails due to missing flametiles plugin directories in src/

Steps to reproduce the behavior:

1. Download the v1 asset, extract and file retrodebugger which results in retrodebugger: ELF 64-bit LSB pie executable, ARM aarch64
2. checkout repository
3. run ./build-linux.sh
4. fails with

CMake Error at CMakeLists.txt:239 (add_library):
  Cannot find source file:

    .../RetroDebugger/src/Plugins/FlameTiles/C64DebuggerPluginFlameTiles.h

5. ls src/Plugins shows that there is no FlameTiles directory as shows the source in github

• OS: CachyOS Linux
• x64

[soenkeraufeisen]

Yes, exactly the same problem here.

[slajerek]

These are my WIP leftover plugins references, it's easy to fix I think by just commenting out missing files in src/Plugins folder in the CMakeFiles file. Sorry I thiught I already cleaned that up. I am now at X Party, will take a look when I'm back.

[srmo]

commenting out missing files in src/Plugins folder in the CMakeFiles file.

I will give this a try. Was just wondering if they are "essential" so I take it as "no" :)

I am now at X Party

have fun! 🥇

[slajerek]

I have added a fix:
a8fb6ed

Please pull and let me know if this compiles for you @srmo

[slajerek]

This is fixed.

[srmo]

@slajerek thanks! Just wanted to give feedback here too, even if it is closed. Using 970280e (latest master) works for the problems with the missing plugin dirs. But now gives me compilation errors

In file included from /RetroDebugger/src/Tools/TextEditor/TestTextEditor.cpp:3:
/RetroDebugger/src/Tools/TextEditor/TextEditor.h:134:17: error: ‘uint8_t’ does not name a type
  134 |         typedef uint8_t Char;
      |                 ^~~~~~~
/RetroDebugger/src/Tools/TextEditor/TextEditor.h:138:17: error: ‘Char’ does not name a type; did you mean ‘char’?
  138 |                 Char mChar;
      |                 ^~~~
      |                 char
/RetroDebugger/src/Tools/TextEditor/TextEditor.h:144:27: error: expected ‘)’ before ‘aChar’
  144 |                 Glyph(Char aChar, PaletteIndex aColorIndex) : mChar(aChar), mColorIndex(aColorIndex),
      |                      ~    ^~~~~~
      |                           )
/RetroDebugger/src/Tools/TextEditor/TextEditor.h:387:9: error: ‘uint64_t’ does not name a type
  387 |         uint64_t mStartTime;
      |         ^~~~~~~~

but this may be me, I'm not that deep into c(++) and the build environment. Not sure if I should open a new issue for that. I'll check out the release artifact

[slajerek]

The fun fact is that this build perfectly passed on GutHub's CI/CD on Linux. I'll check, probably your system lacks some default include.

[srmo]

Thanks. I just figured with the help of AI that I was too clever and only pasted the error and not one of the warnings sprinkled in between the errors:

RetroDebugger/src/Tools/TextEditor/TextEditor.h:12:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’
   11 | #include "imgui.h"
  +++ |+#include <cstdint>
   12 |

The idea seems to be that the explicit include would be required on my system as a default/indirect include is not given on my system, as you already suggested.

Additional details from my environment.
Build logs:

ompiling MTEngineSDL library
CMAKE_BUILD_TYPE=RelWithDebInfo
-- Warning: ccache not found - consider installing it for faster compilation or disable this warning with GGML_CCACHE=OFF
-- CMAKE_SYSTEM_PROCESSOR: x86_64
-- GGML_SYSTEM_ARCH: x86
-- Including CPU backend
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
-- Could NOT find OpenMP (missing: OpenMP_CXX_FOUND) (found version "5.2")
CMake Warning at other/lib/llama.cpp/ggml/src/ggml-cpu/CMakeLists.txt:84 (message):
  OpenMP not found
Call Stack (most recent call first):
  other/lib/llama.cpp/ggml/src/CMakeLists.txt:445 (ggml_add_cpu_backend_variant_impl)


-- x86 detected
-- Adding CPU backend variant ggml-cpu: -march=native
-- ggml version: 0.9.11
-- ggml commit:  3bd9aa1f9
-- Configuring done (0.4s)
-- Generating done (0.1s)
-- Build files have been written to MTEngineSDL/build

compiler versions:

cmake --version
cmake version 4.3.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

######
 make --version
GNU Make 4.4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Libstdc++: 16.1.1

Happy to supply any additional information.

[Krahubot]

I'm trying to build on Ubuntu 26.04 and it fails on missing CViewCamera.h on multiple includes, for example in src/Screens/CViewC64.h. Is this an external dependency?

[slajerek]

@Krahubot
CViewCamera.h is here: https://github.com/slajerek/MTEngineSDL/blob/master/src/Engine/GUI/Helpers/CViewCamera.h

Are you sure you updated to the newest version of MTEngineSDL?

@srmo
Please pull both repos and check whether the build now passes on Arch Linux. It looks like GCC 13+ does not include cstdint by default, and that is why it fails on your side.

By the way, GitHub CI/CD is now able to properly build the Linux version of this repository.

[Krahubot]

Are you sure you updated to the newest version of MTEngineSDL?

Thanks, I had old MTEngineSDL. Retro Debugger builds and works after updating it.