From ce965e6bb47b7fe260e0ea6a8055865c00f5e80b Mon Sep 17 00:00:00 2001 From: Yuri Faria Date: Mon, 29 Jul 2019 22:23:29 -0300 Subject: [PATCH 1/2] controller validation --- app/controllers/SlideController.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/controllers/SlideController.js b/app/controllers/SlideController.js index 3795faf..6425b6f 100644 --- a/app/controllers/SlideController.js +++ b/app/controllers/SlideController.js @@ -9,16 +9,22 @@ const robots = { const controller = {}; controller.post = async (req, res) => { - let content = { lang, author, searchTerm, font, prefix, numberOfSlides } = req.body; + let content = { lang = 'en', author = '', searchTerm, font = 'Roboto', prefix, numberOfSlides = 7 } = req.body; content.id = generateRandomId(); + if(!searchTerm) + return res.status(400).json({ error: 'search term missing' }); + + if(numberOfSliddes > 20) + return res.status(400).json({ error: 'number of slides exceeded the limit' }); + try { content = await robots.text.start(content); content = await robots.image.start(content); await robots.powerPoint.start(content); res.json({ slideId: content.id }); } catch(error) { - res.status(400).json({ error }); + res.status(500).json({ error }); } } From 08f046f72562b929672cbb23a44ca8d16aa49400 Mon Sep 17 00:00:00 2001 From: Yuri Faria Date: Sun, 4 Aug 2019 11:41:06 -0300 Subject: [PATCH 2/2] bug: wrong variable name --- app/controllers/SlideController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/SlideController.js b/app/controllers/SlideController.js index 6425b6f..f503b7e 100644 --- a/app/controllers/SlideController.js +++ b/app/controllers/SlideController.js @@ -15,7 +15,7 @@ controller.post = async (req, res) => { if(!searchTerm) return res.status(400).json({ error: 'search term missing' }); - if(numberOfSliddes > 20) + if(numberOfSlides > 20) return res.status(400).json({ error: 'number of slides exceeded the limit' }); try {