From 08ac47a268545ba7a88ea475ca14b67eced349c5 Mon Sep 17 00:00:00 2001 From: Jared Norman Date: Fri, 24 Apr 2026 17:04:56 +0900 Subject: [PATCH] Don't "persist_amounts" This association is autosaved, and Rails knows not to retouch things when autosaving associated records. I did a test to confirm that removing this doesn't change whether the field is persisted. (cherry picked from commit 6106722c6a56878a43dd7d0ef356c73984748dc1) --- core/app/models/spree/in_memory_order_updater.rb | 1 - core/spec/models/spree/in_memory_order_updater_spec.rb | 1 - 2 files changed, 2 deletions(-) diff --git a/core/app/models/spree/in_memory_order_updater.rb b/core/app/models/spree/in_memory_order_updater.rb index c0da548e6c..4a422c3420 100644 --- a/core/app/models/spree/in_memory_order_updater.rb +++ b/core/app/models/spree/in_memory_order_updater.rb @@ -236,7 +236,6 @@ def recalculate_line_item_prices end def persist_totals - shipments.each(&:persist_amounts) log_state_change("payment") log_state_change("shipment") order.save! diff --git a/core/spec/models/spree/in_memory_order_updater_spec.rb b/core/spec/models/spree/in_memory_order_updater_spec.rb index 80ff30bcda..8c78fbe861 100644 --- a/core/spec/models/spree/in_memory_order_updater_spec.rb +++ b/core/spec/models/spree/in_memory_order_updater_spec.rb @@ -575,7 +575,6 @@ module Spree it "updates the shipment amount" do expect(shipment).to receive(:assign_amounts) - expect(shipment).to receive(:persist_amounts) updater.recalculate end end