refactor(web): use sew() instead of bare try/catch in getFileSourceForRepo

The top-level try/catch added to getFileSourceForRepo silently swallowed
unexpected errors with no Sentry capture or log entry. Replace it with
sew(), which provides the same ServiceError conversion plus Sentry
reporting and structured logging.

The inner git-specific catch is preserved unchanged — sew() only handles
anything that escapes it (DB errors, getRepoPath, URL builders, etc.).

Update the sew mock in the test file to catch and convert exceptions,
matching the real sew() behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Gavin Williams

packages/web/src/features/git/getFileSourceApi.test.ts

@@ -44,7 +44,16 @@ vi.mock('next/headers', () => ({
     headers: vi.fn().mockResolvedValue(new Headers()),
 }));
 vi.mock('@/middleware/sew', () => ({
-    sew: async <T>(fn: () => Promise<T> | T): Promise<T> => fn(),
+    sew: async <T>(fn: () => Promise<T> | T): Promise<T> => {
+        try {
+            return await fn();
+        } catch (error) {
+            return {
+                errorCode: 'UNEXPECTED_ERROR',
+                message: error instanceof Error ? error.message : String(error),
+            } as T;
+        }
+    },
 }));
 vi.mock('@/middleware/withAuth', () => ({
     withOptionalAuth: vi.fn(),
@@ -117,7 +126,7 @@ describe('getFileSourceForRepo', () => {
             });
         });
 
-        it('returns UNEXPECTED_ERROR when the database throws (outer catch)', async () => {
+        it('returns UNEXPECTED_ERROR when the database throws (caught by sew)', async () => {
             mockFindFirst.mockRejectedValue(new Error('DB connection refused'));
 
             const result = await getFileSourceForRepo(

packages/web/src/features/git/getFileSourceApi.ts

@@ -26,84 +26,79 @@ export type FileSourceResponse = z.infer<typeof fileSourceResponseSchema>;
 export const getFileSourceForRepo = async (
     { path: filePath, repo: repoName, ref }: FileSourceRequest,
     { org, prisma }: { org: Org; prisma: PrismaClient },
-): Promise<FileSourceResponse | ServiceError> => {
-    try {
-        const repo = await prisma.repo.findFirst({
-            where: { name: repoName, orgId: org.id },
-        });
-        if (!repo) {
-            return notFound(`Repository "${repoName}" not found.`);
-        }
+): Promise<FileSourceResponse | ServiceError> => sew(async () => {
+    const repo = await prisma.repo.findFirst({
+        where: { name: repoName, orgId: org.id },
+    });
+    if (!repo) {
+        return notFound(`Repository "${repoName}" not found.`);
+    }
 
-        if (!isPathValid(filePath)) {
-            return fileNotFound(filePath, repoName);
-        }
+    if (!isPathValid(filePath)) {
+        return fileNotFound(filePath, repoName);
+    }
 
-        if (ref !== undefined && !isGitRefValid(ref)) {
-            return invalidGitRef(ref);
-        }
+    if (ref !== undefined && !isGitRefValid(ref)) {
+        return invalidGitRef(ref);
+    }
 
-        const { path: repoPath } = getRepoPath(repo);
-        const git = simpleGit().cwd(repoPath);
+    const { path: repoPath } = getRepoPath(repo);
+    const git = simpleGit().cwd(repoPath);
 
-        const gitRef = ref ?? repo.defaultBranch ?? 'HEAD';
+    const gitRef = ref ?? repo.defaultBranch ?? 'HEAD';
 
-        let fileContent: string;
-        try {
-            fileContent = await git.raw(['show', `${gitRef}:${filePath}`]);
-        } catch (error: unknown) {
-            const errorMessage = error instanceof Error ? error.message : String(error);
-            if (errorMessage.includes('does not exist') || errorMessage.includes('fatal: path')) {
-                return fileNotFound(filePath, repoName);
-            }
-            if (errorMessage.includes('unknown revision') || errorMessage.includes('bad revision') || errorMessage.includes('invalid object name')) {
-                return unresolvedGitRef(gitRef);
-            }
-            return unexpectedError(errorMessage);
+    let fileContent: string;
+    try {
+        fileContent = await git.raw(['show', `${gitRef}:${filePath}`]);
+    } catch (error: unknown) {
+        const errorMessage = error instanceof Error ? error.message : String(error);
+        if (errorMessage.includes('does not exist') || errorMessage.includes('fatal: path')) {
+            return fileNotFound(filePath, repoName);
         }
-
-        let gitattributesContent: string | undefined;
-        try {
-            gitattributesContent = await git.raw(['show', `${gitRef}:.gitattributes`]);
-        } catch {
-            // No .gitattributes in this repo/ref, that's fine
+        if (errorMessage.includes('unknown revision') || errorMessage.includes('bad revision') || errorMessage.includes('invalid object name')) {
+            return unresolvedGitRef(gitRef);
         }
+        return unexpectedError(errorMessage);
+    }
+
+    let gitattributesContent: string | undefined;
+    try {
+        gitattributesContent = await git.raw(['show', `${gitRef}:.gitattributes`]);
+    } catch {
+        // No .gitattributes in this repo/ref, that's fine
+    }
 
-        const language = gitattributesContent
-            ? (resolveLanguageFromGitAttributes(filePath, parseGitAttributes(gitattributesContent)) ?? detectLanguageFromFilename(filePath))
-            : detectLanguageFromFilename(filePath);
+    const language = gitattributesContent
+        ? (resolveLanguageFromGitAttributes(filePath, parseGitAttributes(gitattributesContent)) ?? detectLanguageFromFilename(filePath))
+        : detectLanguageFromFilename(filePath);
 
-        const externalWebUrl = getCodeHostBrowseFileAtBranchUrl({
-            webUrl: repo.webUrl,
-            codeHostType: repo.external_codeHostType,
-            branchName: gitRef,
-            filePath,
-        });
+    const externalWebUrl = getCodeHostBrowseFileAtBranchUrl({
+        webUrl: repo.webUrl,
+        codeHostType: repo.external_codeHostType,
+        branchName: gitRef,
+        filePath,
+    });
 
-        const baseUrl = env.AUTH_URL;
-        const webUrl = `${baseUrl}${getBrowsePath({
-            repoName: repo.name,
-            revisionName: ref,
-            path: filePath,
-            pathType: 'blob',
-        })}`;
+    const baseUrl = env.AUTH_URL;
+    const webUrl = `${baseUrl}${getBrowsePath({
+        repoName: repo.name,
+        revisionName: ref,
+        path: filePath,
+        pathType: 'blob',
+    })}`;
 
-        return {
-            source: fileContent,
-            language,
-            path: filePath,
-            repo: repoName,
-            repoCodeHostType: repo.external_codeHostType,
-            repoDisplayName: repo.displayName ?? undefined,
-            repoExternalWebUrl: repo.webUrl ?? undefined,
-            webUrl,
-            externalWebUrl,
-        } satisfies FileSourceResponse;
-    } catch (error: unknown) {
-        const errorMessage = error instanceof Error ? error.message : String(error);
-        return unexpectedError(errorMessage);
-    }
-};
+    return {
+        source: fileContent,
+        language,
+        path: filePath,
+        repo: repoName,
+        repoCodeHostType: repo.external_codeHostType,
+        repoDisplayName: repo.displayName ?? undefined,
+        repoExternalWebUrl: repo.webUrl ?? undefined,
+        webUrl,
+        externalWebUrl,
+    } satisfies FileSourceResponse;
+});
 
 export const getFileSource = async ({ path: filePath, repo: repoName, ref }: FileSourceRequest, { source }: { source?: string } = {}): Promise<FileSourceResponse | ServiceError> => sew(() => withOptionalAuth(async ({ org, prisma, user }) => {
     if (user) {