Skip to content

CMakeFile enhancements #6

@chiradip

Description

@chiradip

Issues:

  1. No compiler version check - It sets C++23 as required but doesn't verify the compiler supports the specific C++23 features used (like explicit object parameters)
  2. Missing feature detection - Should check for P0847R7 support specifically

Recommendations:

  1. Add minimum compiler version checks (GCC 13+, Clang 16+, MSVC 19.32+)
  2. Add feature detection for explicit object parameters
  3. Consider providing a fallback implementation for older compilers
  4. Update the README to clearly state compiler requirements

The CMakeLists.txt is technically correct but lacks safeguards to prevent this exact build failure on older compilers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions