-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Issues:
- No compiler version check - It sets C++23 as required but doesn't verify the compiler supports the specific C++23 features used (like explicit object parameters)
- Missing feature detection - Should check for P0847R7 support specifically
Recommendations:
- Add minimum compiler version checks (GCC 13+, Clang 16+, MSVC 19.32+)
- Add feature detection for explicit object parameters
- Consider providing a fallback implementation for older compilers
- Update the README to clearly state compiler requirements
The CMakeLists.txt is technically correct but lacks safeguards to prevent this exact build failure on older compilers.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels