Send ACK even if not all parameters in push request are recognised#79
Open
troelsjessen wants to merge 1 commit into
Open
Send ACK even if not all parameters in push request are recognised#79troelsjessen wants to merge 1 commit into
troelsjessen wants to merge 1 commit into
Conversation
Contributor
|
Why dont we make it an option on the client side, wether they would like full ack of all set params, ack if only a partial was set, or simply just a return of all the set parameters? |
Contributor
Author
You want another flag in the push request, selecting whether to send an ACK if only some parameters were recognised? Currently, Recent releases of CSH is always setting ack with pull. Currently we have the following flags defined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When typing
switch Xin CSH, the client throws apush queue errorafter the configured timeout and the module is leaving aParam serve push error, result = -1in stdbuf due to the client also setting parameters boot_img2/3 in case they exist.Since ack_with_pull was introduced, the user will see the parameters actually set in the ACK, so I see not reason why the server simply shall hold back the ACK in case not all values can be handled.