From 9cfc10d9bbb7379f84f00595554619c387f915a5 Mon Sep 17 00:00:00 2001 From: Ophir LOJKINE Date: Mon, 16 Mar 2026 21:43:08 +0100 Subject: [PATCH 1/2] Log non-2xx HTTP responses in request completion log --- src/webserver/http.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/webserver/http.rs b/src/webserver/http.rs index 1d0e31e7..7d4fad05 100644 --- a/src/webserver/http.rs +++ b/src/webserver/http.rs @@ -371,12 +371,16 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder { DefaultRootSpanBuilder::on_request_end(span, outcome); // Emit a single log event per completed request so it appears in logs. - // Error responses (4xx/5xx) are already logged by our error handlers. let _enter = span_ref.enter(); if let Ok(response) = outcome { let status = response.response().status(); - if status.is_success() || status.is_redirection() { - log::info!("{}", status.canonical_reason().unwrap_or("ok")); + let reason = status.canonical_reason().unwrap_or("Unknown Status"); + if status.is_server_error() { + log::error!("{status} {reason}"); + } else if status.is_client_error() { + log::warn!("{status} {reason}"); + } else { + log::info!("{status} {reason}"); } } } From 553fa5712dfdf10dcec5f381b619221dc4c71442 Mon Sep 17 00:00:00 2001 From: Ophir LOJKINE Date: Tue, 17 Mar 2026 11:34:41 +0100 Subject: [PATCH 2/2] fix log message --- src/webserver/http.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/webserver/http.rs b/src/webserver/http.rs index 7d4fad05..7dc4d42d 100644 --- a/src/webserver/http.rs +++ b/src/webserver/http.rs @@ -374,14 +374,14 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder { let _enter = span_ref.enter(); if let Ok(response) = outcome { let status = response.response().status(); - let reason = status.canonical_reason().unwrap_or("Unknown Status"); - if status.is_server_error() { - log::error!("{status} {reason}"); + let level = if status.is_server_error() { + log::Level::Error } else if status.is_client_error() { - log::warn!("{status} {reason}"); + log::Level::Warn } else { - log::info!("{status} {reason}"); - } + log::Level::Info + }; + log::log!(level, "{status}"); } } }