From bce41ad7cef7cd732559d6b4e454ef9aee3719e7 Mon Sep 17 00:00:00 2001 From: Nick Sillik Date: Mon, 8 Sep 2025 13:50:20 -0400 Subject: [PATCH] feat(ios): Remove check of iOS 16.4 Workaround feature flag. POS is no longer using this feature flag ([PR](https://github.com/squareup/ios-register/pull/132564)) and this workaround has been in the wild long enough that we're comfortable continuing to use it by default. --- CHANGELOG.md | 2 ++ .../ListView/ListView+iOS16.4Workaround.swift | 13 ------------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6178a4c15..e4af49b01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ ### Changed +- The iOS 16.4 first responder workaround no longer checks UserDefaults, the workaround is always applied. + ### Misc ### Internal diff --git a/ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift b/ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift index b0316f934..390a191ea 100644 --- a/ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift +++ b/ListableUI/Sources/ListView/ListView+iOS16.4Workaround.swift @@ -263,19 +263,6 @@ extension ListView { return super_function(self, selector) } - /// In case this workaround goes wrong somehow, we'll write a go/feature controlled flag - /// into `UserDefaults` in POS, and then read it here. This will allow us to disable the workaround - /// remotely if needed. - /// - /// Note: We are explicitly **not** making this a static value, so it can be changed across reads. - let workaroundEnabled = UserDefaults.standard.object( - forKey: "Listable.EnableIOS164FirstResponderWorkaround" - ) as? NSNumber ?? NSNumber(booleanLiteral: true) - - guard workaroundEnabled.boolValue == true else { - return super_function(self, selector) - } - guard Self.hasFirstResponderViewProperty else { assertionFailure("UICollectionView no longer has an ivar named `_firstResponderView`.") return super_function(self, selector)