Skip to content

AssertionError when deserializing to a record when using maven-shade-plugin #2117

Description

@tyilo

pom.xml:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>org.example</groupId>
    <artifactId>moshi-test</artifactId>
    <version>1.0-SNAPSHOT</version>

    <properties>
        <maven.compiler.source>17</maven.compiler.source>
        <maven.compiler.target>17</maven.compiler.target>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>

    <dependencies>
        <dependency>
            <groupId>com.squareup.moshi</groupId>
            <artifactId>moshi</artifactId>
            <version>1.15.2</version>
        </dependency>
    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-shade-plugin</artifactId>
                <version>3.6.2</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>shade</goal>
                        </goals>
                        <configuration>
                            <finalName>${targetName}</finalName>
                            <transformers>
                                <transformer
                                        implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
                                    <manifestEntries>
                                        <Main-Class>org.example.Main</Main-Class>
                                    </manifestEntries>
                                </transformer>
                            </transformers>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>
</project>

src/main/java/org/example/Main.java:

package org.example;

import com.squareup.moshi.Moshi;

import java.io.IOException;

public class Main {
    public static void main(String[] args) throws IOException {
        var moshi = new Moshi.Builder().build();
        var adapter = moshi.adapter(Foo.class);
        var result = adapter.fromJson("{\"bar\": \"baz\"}");
        System.out.println(result);
    }

    public record Foo(String bar) {}
}

Reproduction:

$ mvn package
$ java -jar target/moshi-test-1.0-SNAPSHOT.jar 
Exception in thread "main" java.lang.AssertionError
	at com.squareup.moshi.ClassJsonAdapter.fromJson(ClassJsonAdapter.java:210)
	at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
	at com.squareup.moshi.JsonAdapter.fromJson(JsonAdapter.java:70)
	at org.example.Main.main(Main.java:11)

Running without the uberjar works:

$ java -classpath target/classes:/$HOME/.m2/repository/com/squareup/moshi/moshi/1.15.2/moshi-1.15.2.jar:/$HOME/.m2/repository/com/squareup/okio/okio-jvm/3.7.0/okio-jvm-3.7.0.jar:/$HOME/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib/1.9.21/kotlin-stdlib-1.9.21.jar:/$HOME/.m2/repository/org/jetbrains/annotations/13.0/annotations-13.0.jar:/$HOME/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib-jdk8/1.8.21/kotlin-stdlib-jdk8-1.8.21.jar:/$HOME/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib-jdk7/1.8.21/kotlin-stdlib-jdk7-1.8.21.jar org.example.Main
Foo[bar=baz]

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions